Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http.createServer().listen() should return a Server instance #1276

Closed
opichals opened this issue Nov 16, 2017 · 1 comment
Closed

http.createServer().listen() should return a Server instance #1276

opichals opened this issue Nov 16, 2017 · 1 comment

Comments

@opichals
Copy link
Contributor

server.listen() is void unlike the node.js implementation where it returns an instance of the server.

As the fix is trivial it appears to be worth fixing for better developer compatibility.
@gfwilliams
Copy link
Member

Just fixed :)

Also I noticed that dgram.bind returned the parent without locking it again - but fixing it causes memory leaks - so I think there might be something iffy going on with locks in dgram - perhaps an extra lock somewhere else where there shouldn't be one... It might be worth looking into as it could cause problems later on?

@opichals opichals mentioned this issue Nov 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@opichals @gfwilliams