Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ESP32 jshGetSystemTime() make interrupt tolerant #1285

Merged
merged 1 commit into from Dec 9, 2017

Conversation

wilberforce
Copy link
Member

Pull @jumjum123 changes from ESP32 branch into master

Pull @jumjum changes from ESP32 branch into master
@gfwilliams gfwilliams merged commit 6678cc3 into master Dec 9, 2017
@opichals
Copy link
Contributor

opichals commented Dec 9, 2017

Perhaps there should be an initializer like this instead of just undefined content?

   portMUX_TYPE mux = portMUX_INITIALIZER_UNLOCKED;

Adding an interesting article link about the ESP32 synchronization stuff https://techtutorialsx.com/2017/09/30/esp32-arduino-external-interrupts/

@gfwilliams
Copy link
Member

Just added that for you.

@wilberforce
Copy link
Member Author

@gfwilliams

Thanks Gordon - that was unexpected!

@gfwilliams
Copy link
Member

Just saves everyone some time if it's a one-liner :)

@wilberforce wilberforce deleted the wilberforce-patch-2 branch December 14, 2017 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants