Quickfix for not working chips #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! I think maybe it's worth just removing the 'id' link if someone tries to use the search box or chips, so they don't end up with a 'locked' app loader. I'll get a tweak in for that now |
|
Also - thanks for jumping on this so quickly - it's really appreciated! |
Thank you for looking into improving this.
Well, i introduced this bug so i feel a bit responsible to solve it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix the non working chips reported in http://forum.espruino.com/conversations/373111/
Sorry for that.
But it remains a problem: When a single app is pre-selected via URL?id=antonclk the chips are not working. I guess we can simply hide the chips when a single app is opened via ?id URL?