Esp32 neopixel debug #1621
Merged
Esp32 neopixel debug #1621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 20, 2019 00:37
…t commit more well-understandable
Also simplify neopixel_bits init, some debug in interrupt usage and in call with zero size buffer.
|
Forum post about this here: http://forum.espruino.com/conversations/330748/#comment14644546 |
|
@MaBecker should I merge this? You seem to do quite a bit of neopixel stuff, so does it improve life for you? |
|
Well the existing Neopixel implementation is working as expected.
NO |
|
Ok, thanks! Actually looking at the code again and at http://forum.espruino.com/conversations/330748/#comment14644546 it looks entirely likely that the existing ESP32 code had issues with longer strings of neopixels (also this code is a bit tidier than before) so merging anyway. |
|
Did some tests with up to 300 pixel, still works as expected :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Here is some fixes to esp32 neopixel from SergeP. Improved slightly from forum version to be more readable.