Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Terminal logger - option to save to localStorage #252

Merged
merged 1 commit into from Jun 14, 2021

Conversation

AkosLukacs
Copy link
Contributor

So you don't lose data if you forget it, or accidentally close the tab

So you don't lose data if you forget it, or accidentally close the tab
@AkosLukacs
Copy link
Contributor Author

There is a separate setting option to enable it, so it's not on by default.

There is one caveat: if this grows larger than the quota, well, things can start to fail :/ Maybe remove data from localStorage when the user unticks the save to localStorage option?

One possible problem, if data comes in really fast. But not sure how fast could be too fast...

@gfwilliams
Copy link
Member

Nice - thanks! Seems like a really good idea.

@gfwilliams gfwilliams merged commit afbd63d into espruino:master Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants