New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BLE GATT Battery Service #542
Conversation
Thanks! Looks great! I guess it doesn't need to be a widget (could just be boot code) but at least this way you can extend it to display data if you want to later |
Where would it live if it was boot code? Would it still be something people can choose to install, or would it always run for everyone? |
That's great! I'm going to have to give home assistant a go :)
Basically the same as right now: still in apps.json, but just However if you remove the |
I decided to change it to boot code. Should the type still be "widget", or should it be "app", or something else? |
I'd make it |
Should I rebase to fix the conflict? I know that can make the "Files changed" diff go a bit crazy once the PR has been opened. |
No, that's fine - I just did the merge here. I'll just wait for the CI check to complete and then I'll merge this :) |
Thanks! All sorted - it'll be live on the development apps repo now, and hopefully banglejs.com/apps when I push an update in a day or two |
This is the battery service widget that we talked about here http://forum.espruino.com/conversations/351959/.
There are probably a few tweaks to be made.