Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bootgatthrm]: Extract HRM Sensor Data into Separate Bootloader App #2802

Merged
merged 3 commits into from Jun 9, 2023
Merged

[bootgatthrm]: Extract HRM Sensor Data into Separate Bootloader App #2802

merged 3 commits into from Jun 9, 2023

Conversation

AnotherStranger
Copy link
Contributor

This pull request aims to extract the features introduced in pull request #2798 into a new bootloader app. The primary focus of this PR is the creation of a boot code that exposes the HRM sensor data over BLE. By separating this functionality into a standalone service, users will have the flexibility to install and utilize it independently.

Changes Made:

@gfwilliams thank you for your guidance and valuable Feedback!!

@AnotherStranger AnotherStranger changed the title [WIP] [bootgatthrm]: Extract HRM Sensor Data into Separate Bootloader App [bootgatthrm]: Extract HRM Sensor Data into Separate Bootloader App Jun 9, 2023
@gfwilliams
Copy link
Member

This looks great, thanks!

This won't actually turn the HRM on, but if the HRM is on for any other app (run, or the health monitoring for instance) then it'll send the current HRM over - but I think that's probably good behaviour?

@gfwilliams gfwilliams merged commit 0e47f36 into espruino:master Jun 9, 2023
1 check passed
@AnotherStranger
Copy link
Contributor Author

This looks great, thanks!

This won't actually turn the HRM on, but if the HRM is on for any other app (run, or the health monitoring for instance) then it'll send the current HRM over - but I think that's probably good behaviour?

@gfwilliams
I didn't turn on HRM intentionally. I tried to minimize battery drain caused by the bootcode.
However, I could implement a settings page which allows the user to control this behaviour. If there is demand for this feature.

I have one question remaining: When does the bangle call boot.js files? On every reload?
Sorry, if this is an obvious thing I might have missed...

@gfwilliams
Copy link
Member

Yes, I think that's the right idea at the moment re: HRM. Just thought I'd mention in case you hadn't thought of it.

When does the bangle call boot.js files? On every reload?

Pretty much, yes. When an app/clock/etc is loaded - it's needed because generally we tear everything down and put it back to ensure the watch doesn't get unreliable if one app wasn't behaving.

But we do now have 'fast load' especially for clocks, and then those don't call boot code again (but nothing gets torn down either)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@AnotherStranger @gfwilliams