Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings missing brightness #186

Closed
marcocastignoli opened this issue Apr 2, 2020 · 4 comments · Fixed by #234
Closed

Settings missing brightness #186

marcocastignoli opened this issue Apr 2, 2020 · 4 comments · Fixed by #234

Comments

@marcocastignoli
Copy link
Contributor

In the settings app there is no brightness selector. For now I made an app for managing brightness:

I created a widget that doesn't draw anything but set the brightness taking the value from a value save in the storage by my new brightness app.
Then I had to edit the launch.app.js because widgets are not loaded there.

But I think it would be easier to have the brightness selector inside the settings app :)
@detached detached mentioned this issue Apr 5, 2020
Merged
@gfwilliams
Copy link
Member

Reopen because PR won't auto-load settings at boot.

It'll need something in settings.boot.js as well I imagine...

@gfwilliams gfwilliams reopened this Apr 6, 2020
@Didgeridoohan
Copy link
Contributor

From what I see it doesn't even keep the setting after you've left the Settings app. The LCD brigthness changes as you change the setting, but as soon as you go back out it goes back to full brightness. The setting value is saved in the menu, but does nothing (until you go back and change the value again, but as previously the result is temporary).

It might also be a good idea to limit the min value to 0.1, so that it isn't possible to accidentally turn off the LCD completely.

@gfwilliams
Copy link
Member

Thanks, yes - that's why this issue is still left open...

@Didgeridoohan
Copy link
Contributor

Didn't first realise that I was actually reporting the exact same issue as you where... Now I get you.

I'm still trying to learn how everything is set up. Works fine now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adds LCD brightness setting detached/BangleApps
3 participants
@gfwilliams @marcocastignoli @Didgeridoohan