New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
wid_edit: Widget Editor #1303
wid_edit: Widget Editor #1303
Conversation
Thanks! So...
I think so, yes... I mean with
I think for disabling we should just ask the user to uninstall. But maybe you could switch to hiding? This seems quite successful and is already used a few places: BangleApps/apps/widviz/widget.js Lines 10 to 11 in 9b4d2e1
|
It tries to hide them now, and could probably try a bit harder (and properly label it "hide" instead of "disable"), but "just ask the user to uninstall" seems like the better way. Also because otherwise you end up with a whole bunch of widget code loaded for no good reason, and it would mean much cleaner code for this app. I'll update it to just support |
0cd2503
to
3468e12
Compare
to keep boot code as small as possible
Updated to just support tl/tr and sortorder. |
Thanks! |
Widget Editor, so we don't need to edit code to move our widgets around.
Every feature seems like a good idea while happily coding away, but "disabling" widgets is tricky. I think it works fine with most widgets, but they are still loaded.
And apps that try to call
WIDGETS[<myappid>].someCustomFunction()
probably break.Maybe better to strip this out, and if people want to get rid of a widget we adjust that app? (Maybe someday we can come up with a standard setting for this, so apps don't all need to build their own "show widget?" setting)
Also, maybe we should "officially" get rid of bottom widgets?
Bangle.appRect
doesn't looks like it supports it for one...The only bottom widget is
wdclkbttm
, I haven't tried that particular one, but it seems Things (like menus) Break with bottom widgets.With all the "disabled"/bottom row breakage, I figured this should be a separate app.
But if we strip out disabling, and only allow choosing between "top left"/"top right", maybe this could go directly into the settings app?