@gfwilliams I am really sorry to have caused a bad release. I hope that the benefits outweigh the trouble caused.

Thank you for the detailed repro instructions. A fix is ready in #1408.

No problem - I should have had tests that covered it better, so thanks for tweaking the existing net test as well.

And yes, the benefits of your commits absolutely outweigh this one very small issue :)

this is still an issue in the latest release. i cannot fully test, as i cannot complete my onInit() code. in wifi 1v97.62, i cannot complete a connection with espruino as the ws server and a webpage as the ws client. this does work in 1v96.

@Jason-CloudTP

Are you able to provide a simple test case with source files (use gist?) so that the issue can be produced easily to aid debugging?

sure. when using the server url in a browser, the client never connects via websocket.

`var WebSocket = require("ws");

var WIFI_NAME = "";
var WIFI_OPTIONS = { password : "" };

var wifi;

function onInit() {
wifi = require("Wifi");
wifi.connect(WIFI_NAME, WIFI_OPTIONS, function(err) {
if (err) {
console.log("Connection error: "+err);
return;
}
console.log("Connected!");
wifi.getIP(function (err, ip) {
console.log(JSON.stringify(ip));
});
startServer();
});
}

var page = '<script>var ws;setTimeout(function(){';
page += 'ws = new WebSocket("ws://" + location.host + "/my_websocket", "protocolOne");';
page += 'ws.onmessage = function (event) { console.log("MSG:"+event.data); };';
page += 'setTimeout(function() { ws.send("Hello to Espruino!"); }, 1000);';
page += '},1000);</script>';

function onPageRequest(req, res) {
res.writeHead(200, {'Content-Type': 'text/html'});
res.end(page);
}

function startServer() {
server = require('ws').createServer(onPageRequest);
// server = require('ws').createServer();
server.listen(8000);
server.on("websocket", function(ws) {
ws.on('message',function(msg) { print("[WS] "+ msg); });
ws.send("Hello from Espruino!");
});
}`

I can confirm that the code fails on the unix build:

var page = '<script>var ws;setTimeout(function(){';
page += 'ws = new WebSocket("ws://" + location.host + "/my_websocket", "protocolOne");';
page += 'ws.onmessage = function (event) { console.log("MSG:"+event.data); };';
page += 'setTimeout(function() { ws.send("Hello to Espruino!"); }, 1000);';
page += '},1000);</script>';

function onPageRequest(req, res) {
res.writeHead(200, {'Content-Type': 'text/html'});
res.end(page);
}

function startServer() {
server = require('ws').createServer(onPageRequest);
// server = require('ws').createServer();
server.listen(8000);
server.on("websocket", function(ws) {
ws.on('message',function(msg) { print("[WS] "+ msg); });
ws.send("Hello from Espruino!");
});
}
startServer();

The code above works on:

git checkout RELEASE_1V96

in the console in chrome:

MSG:Hello from Espruino!

@wilberforce Thanks for isolating it. Fix is in #1415.