Extended filtering #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me! Not sure if you have any idea but it seems like some kind of small 'copy link' button might be neat on apps so that it's obvious how to share them. On the forum I find I often want to say 'look at the readme for X' - so I wonder if there's a way to do that... |
I will have a look at this - should not be that hard. |
|
Thanks - that'd be great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible filter types:
.../BangleApps/#blueshows apps having "blue" in app.id or app.tag --> searchType:hash (as before these changes).../BangleApps/#bluetoothshows apps having "bluetooth" in app.id or app.tag (also selects bluetooth chip) --> searchType:chip (as before these changes).../BangleApps/id=antonclkshows app having app.id == antonclk --> searchType:id.../BangleApps/q=clockshows apps having "clock" in app.id or app.description --> searchType:fullTyping in the search field on the web interface does full search now (and the URL is changed according to the input value).
Fixes espruino/BangleApps#1215
Note: there is no change in the sorting as suggested in comment espruino/BangleApps#1215 (comment) done.
@gfwilliams even though i tested this i would like you to have a second look on this before merging :) Thanks!