Fix drawString and setClipRect with 90/270-degree rotation
#2343
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the calculation of `minX`, `minY`, `maxX`, and `maxY` inside `jswrap_graphics_drawString` was what `graphicsToDeviceCoordinates` does, just written out explicitly. With 90- or 270-degree rotations, that meant that the final values ended up rotated 180 degrees relative to what they should have been. As a result, characters could end up effectively clipped twice and hence incorrectly not being drawn. What we actually want instead is to do the _reverse_ transformation of `graphicsToDeviceCoordinates`, which fortunately already exists as `deviceToGraphicsCoordinates`.
|
Thanks - this looks great! I was sure there was a reason it was done that way, but I can't remember now - maybe it's just that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the calculation of
minX,minY,maxX, andmaxYinsidejswrap_graphics_drawStringwas whatgraphicsToDeviceCoordinatesdoes, just written out explicitly. With 90- or 270-degree rotations, that meant that the final values ended up rotated 180 degrees relative to what they should have been. As a result, characters could end up effectively clipped twice and hence incorrectly not being drawn. What we actually want instead is to do the reverse transformation ofgraphicsToDeviceCoordinates, which fortunately already exists asdeviceToGraphicsCoordinates.The PR includes a test that would fail before and is fixed by this change.