Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[gbmusic] Allow play/pause to work without music info #1027

Closed
Saduff opened this issue Dec 8, 2021 · 8 comments
Closed

[gbmusic] Allow play/pause to work without music info #1027

Saduff opened this issue Dec 8, 2021 · 8 comments

Comments

@Saduff
Copy link

Saduff commented Dec 8, 2021

When using the Gadgetbridge Music Controls app with Spotify, no music info is displayed (e.g. track, artist) and also the state (playing/paused) is unknown. Because of that, the app is always sending the play command. I propose to toggle play/pause on every touch (alternating between the two) when music info cannot be obtained. All other controls (previous/next track, volume up/down) work fine.

@gfwilliams
Copy link
Member

What device is this on? Because usually I'd say just use Android/Messages and there's a specific entry for music playing which displays all the info

@Saduff
Copy link
Author

Saduff commented Dec 8, 2021

The device is Xiaomi Mi 11. But I thought Android/Messages is only for notifications or am I missing something? And just realized that music info also comes from a notification. Is Messages supposed to show it? In any case, I'm more interested in the music controls than the music info, but of course it's better to also have the music info.

Also, I realized why music info didn't show up with Spotify. I had Gadgetbridge configured to only allow notifications from selected apps and Spotify was not selected. After adding Spotify to the list, the music info showed up and the music controls app is working properly. However, it might still be worthwhile to implement what I suggested in case some unknown Android music app does not show a notification about what's playing. At least all the controls should still work then.

@gfwilliams
Copy link
Member

I thought Android/Messages is only for notifications or am I missing something?

The idea is the Android app handles all Android integration (including music) - there are music controls too. It's basically a replacement for Gadgetbridge, but the idea is rather than duplicating a bunch of work for Android and iOS, the two apps (Android/iOS) forward the info to the Messages app, and then we can have one app to handle music/messages/etc that doesn't care what phone you have.

But yes, good point on the toggling. It could toggle automatically and if Gadgetbridge did update play state, it would just overwrite it with the same.

@Saduff
Copy link
Author

Saduff commented Dec 9, 2021

Oh, I see. I found the music controls in the Messages app now. However, I think it's missing some features that the Gadgetbridge Music Controls app has:

  1. Volume control
  2. Previous song (I can only see a button for next song)
  3. Auto start when playing music

@gfwilliams
Copy link
Member

Ahh - yes, good point. It'd be nice to add things like that. I guess prev/next/vol could be done with swipes?

@rigrig
Copy link
Contributor

rigrig commented Feb 21, 2022

I don't have an iPhone, but it looks as if using Bangle.musicControl should work universally.
If so I think we should probably get rid of the gbmusic app, and just move that code into messages.

That also allows us to get rid of the "override GB for music events" stuff, and handle receiving a "real" message while playing music smoother. (i.e. go back to the music screen after reading the message)

@gfwilliams
Copy link
Member

Definitely - I'm all in favour of trying to reduce duplicated functionality

@thyttan
Copy link
Collaborator

thyttan commented Dec 2, 2022

Candidate for being closed - leave a comment if you object!

Rationale:
If gbmusic is kind of deprecated by now, I suggest closing this. Maybe keep it and change name or open a new issue regarding adding 'previous'-action and swipes for input - but some of these things are already on the way in the different new message ui projects, e.g. @rigrig's smessages.

@Saduff Saduff closed this as not planned Won't fix, can't repro, duplicate, stale Dec 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants