Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix run bug where recorder did not stop. #1628

Merged
merged 2 commits into from Mar 28, 2022
Merged

Fix run bug where recorder did not stop. #1628

merged 2 commits into from Mar 28, 2022

Conversation

GrandVizierOlaf
Copy link
Contributor

I introduced a bug in run version 0.11 after misreading an if statement and recorder would no longer stop at the end of a run. This fixes that.

@gfwilliams
Copy link
Member

I'm pretty sure this breaks the code.

What if you don't have recorder installed? You'll get an exception from WIDGETS["recorder"].setRecording when stopping recording

@gfwilliams gfwilliams closed this Mar 28, 2022
@BartS23
Copy link
Contributor

BartS23 commented Mar 28, 2022

No, it does not break the code because it is already covered in line 52
https://github.com/espruino/BangleApps/blob/master/apps/run/app.js#L52

@gfwilliams
Copy link
Member

Thanks! Sorry, didn't spot that :)

@gfwilliams gfwilliams reopened this Mar 28, 2022
@gfwilliams gfwilliams merged commit e482707 into espruino:master Mar 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GrandVizierOlaf @gfwilliams @BartS23