Add loyalty cards app #2977
Add loyalty cards app #2977
Conversation
This app will be able to render cards as synchronized by Catima
glemco
force-pushed
the
cards
branch
4 times, most recently
from
2029dd3
to
15f9693
Compare
|
This is cool :) Not sure if expected (still new to the Bangle), but I am unable to go back after opening a QR code - I must hold the button to go back to the watchface. Is this expected? |
|
Thanks for trying it out! |
|
Oh wow - it's possible to double-tap the actual device 🤯 Couldn't we make single-tap on the button go back? |
|
Yeah that's another idea, I could try it out 👍 |
glemco
force-pushed
the
cards
branch
2 times, most recently
from
e67a034
to
12720c5
Compare
|
Cool idea - I'll let Gordon merge this as it's modified the console.log("Wrong cards event structure " + event); //TODO remove this |
glemco
force-pushed
the
cards
branch
2 times, most recently
from
b9b096c
to
672a047
Compare
|
Thanks @bobrippling for spotting this! Fixed and I'd say it's quite ready to go (of course considering the limitations I mentioned in the README) |
|
Thanks! One more thing I've just thought - is the C qrcode under any particular license? |
|
Both QR and barcode libs are under MIT, I linked them in the README. Should I add the licenses to this repo too? |
| @@ -236,6 +236,11 @@ | |||
| event.t="remove"; | |||
| } | |||
| require("messages").pushMessage(event); | |||
| }, | |||
| "cards" : function() { | |||
There was a problem hiding this comment.
Please could you just add a comment here saying this is for the 'cards' app?
|
Wrt licenses, please could you add a comment at the top of each of the JS files (just what they're based on and what the license is) - I think that'd be ok for us with it in the README as well. It looks good to me (although I guess in an ideal world the |
|
@gfwilliams thanks for the answer, I updated the files. Yeah I was thinking it wasn't a good way to add yet another handler there but just went with the flow.. |
|
Great - thanks! |
Simple app to display loyalty cards synced from Catima through GadgetBridge.
The app can display the cards' info (balance, expiration, note, etc.) and tapping on the appropriate field will display the code, if the type is supported.
This is pretty much a proof of concept, many codes may be too complex to be rendered by the bangle's screen or hardware (at least with the current logic).
Simple synchronization support is added in https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/3268 .
We send all cards in one go after pressing the button in GB, just like it is implemented on ZeppOS. We may think of some way (like hard limiting the number of cards) to avoid loading too many and crash the device. Right now it's responsibility of the user not to overload the watch. Any synchronization is overwriting the file.
Any help or comment is highly appreciated.