Encoder module: Pins will be checks during initialization and module state will be calculated correctly. #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks! |
gfwilliams
added a commit
that referenced
this pull request
Nov 3, 2015
Encoder module: Pins will be checks during initialization and module state will be calculated correctly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The encoder module did not check the states of the two input pins. this.last was set to 0 while PINA and PINB could be 1.
This leads to the strange behavior that the first rotary movement could result in +1/-1 while the following movement will result in +2/-2.
This pull request uses the available onChange() method to initialize the state of the module without changing any other behavior.