added support for ADS1115 in ADS1X15 module #665
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gfwilliams
reviewed
Aug 24, 2022
| @@ -92,10 +93,12 @@ var REG = { | |||
| LOWTHRESH : 2, | |||
| HITHRESH : 3 | |||
| }; | |||
| function ADS1X15(i2c) { | |||
| function ADS1X15(i2c,opts={part:"ads1015"}) { | |||
There was a problem hiding this comment.
I'm afraid Espruino doesn't support default arguments, so I don't believe this code will even run on Espruino unless the minifier is smart enough to transpile it
|
Thanks! I'll merge this, but will tweak the default argument manually here |
gfwilliams
added a commit
that referenced
this pull request
Aug 24, 2022
…e DR_ADS1115_860SPS wouldn't have worked
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this discussion : http://forum.espruino.com/conversations/378555/#comment16639545