GPS Info App: Added number of satellites in view and fixed crash with GPS time #1167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. (bugfix) Workaround for a crash in toUTCString() if fix.time has the value "undefined", see #1155 2. (improvement) The 4-dot progress indicator is replaced by the number of satellites in view. Tested on Bangle.js 2 with firmware 2v11
BartS23
reviewed
Dec 23, 2021
Sum up number of GPS and Beidou satellites in view.
HilmarSt
changed the title
HilmarSt
changed the title
BartS23
reviewed
Jan 2, 2022
BartS23
reviewed
Jan 2, 2022
…d as numbers) Co-authored-by: BartS23 <10829389+BartS23@users.noreply.github.com>
...otherwise one of them is always zero. Thanks, BartS23
HilmarSt
changed the title
|
Thanks! In future please could you update the version in apps.json and the Changelog? I'll do this now though |
gfwilliams
added a commit
that referenced
this pull request
Jan 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested on Bangle.js 2 with firmware 2v11