New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove NDEFWriter #589

Merged

gfwilliams merged 1 commit into espruino:master from beaufortfrancois:patch-6

Jan 4, 2021

Contributor

beaufortfrancois commented Dec 31, 2020

This PR updates Web NFC API to reflect latest spec changes.
See https://github.com/w3c/web-nfc/blob/gh-pages/EXPLAINER.md#changes-done-after-origin-trial-ot and https://web.dev/nfc/

Note that the first call ndef.scan() will fail if permission was not granted before as a user gesture is required.


          Remove NDEFWriter

c6231d3

Member

gfwilliams commented Jan 4, 2021

Great - thanks!

So I guess right now you and up having to do something like:

Load page
Click 'write'
Accept permission prompt
Reload page
Everything works fine?

gfwilliams merged commit c368531 into espruino:master

Contributor Author

beaufortfrancois commented Jan 5, 2021

So I guess right now you and up having to do something like:

Load page

Click 'write'

Accept permission prompt

Reload page

Everything works fine?

Yes! Ideally, I'd go with something like https://web.dev/nfc/#check-for-permission

Contributor Author

beaufortfrancois commented Jan 5, 2021

For info, https://www.espruino.com/Web+NFC#web-page is still not updated. Is this "normal"? @gfwilliams

Member

gfwilliams commented Jan 5, 2021

Thanks!

And yes - I manually pull in the changes from GitHub, then review and update the site. It helps to stop things getting broken ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment