[runplus] New app based on the "Run" app adding Karvonnen UI #2591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 22, 2023 18:53
This reverts commit 026b266. Revert "spelling comment" This reverts commit 9824460. Revert "remove export in karvonnen.js" This reverts commit c681bd8. Revert "change to use eval for launching karvonnen ui" This reverts commit 92a3c48. Revert "tweaks to colors and placings" This reverts commit ff6337b. Revert "tweaks to placing of things" This reverts commit 3ee5c23. Revert "fix HRM settings default" This reverts commit cd001d8. Revert "ChangeLog: alpha->beta" This reverts commit 6c1d709. Revert "remove unnecessary semicolon" This reverts commit 918ab81. Revert "switch to run UI whenever pressing physical button" This reverts commit ebc2916. Revert "after many changes and some testing many things seem to function very well" This reverts commit 5a05b47. Revert "add defaults to hrm settings" This reverts commit 71892cf. Revert "update UI pretty lazily, fix color of bpm" This reverts commit 2e64892. Revert "karvonnen UI now updates with bpm from hrm" This reverts commit d4db5be. Revert "maybe now hrm setting work..." This reverts commit 646ffa2. Revert "settings fix again" This reverts commit 5a8046b. Revert "try fix settings min" This reverts commit 671a407. Revert "fix hrm min setting" This reverts commit ea00567. Revert "fix hrm min setting" This reverts commit 7572ddd. Revert "fix hrm max setting" This reverts commit 2a83b7b. Revert "fix hrm max setting" This reverts commit 4494b48. Revert "add hrm min/max settings" This reverts commit 52c5970. Revert "add/rm semicolons" This reverts commit 1d78542. Revert "fix accidental removal of interval" This reverts commit f2af132. Revert "move karvonnen out of app.js and require it into run.app.js when loading app to the watch" This reverts commit 1df4962. Revert "Revert "remove run.app.karvonnen.js, moved into app.js"" This reverts commit 2ed76d6. Revert "add a comment, remove a print-statement" This reverts commit 9035cc3. Revert "remove commented out lines" This reverts commit 3226756. Revert "remove run.app.karvonnen.js, moved into app.js" This reverts commit 705c2c5. Revert "fix version metadata" This reverts commit ef7f4d3. Revert "ChangLog version" This reverts commit 502b992. Revert "version metadata" This reverts commit 270c3d3. Revert "Move karvonnen code into the run app" This reverts commit e72a4d3. Revert "Update run.app.karvonnen.js" This reverts commit 5313d41. Revert "Add files via upload" This reverts commit 51d62c8.
added 3 commits
February 22, 2023 19:05
…rvonnen ui depending on if we have hrm data or not
thyttan
changed the title
thyttan
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference the forum thread: https://forum.espruino.com/conversations/383175/
I haven't changed the icon. Just adding a plus sign would make sense, but I won't do it now 🙃.
I'm a little worried that I probably have broken git history between run and runplus, so that we won't be able to rebase runplus on top of changes to run if we wanted to. It feels like there should be a better way to do it than what I did.
If it looks good it's ok to merge by me.