Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip uart service check for devices requested by name or MAC #162

Merged
merged 2 commits into from May 4, 2023

Conversation

fanoush
Copy link
Contributor

@fanoush fanoush commented Apr 21, 2023

Do not check for advertised Nordic UART service for BLE devices that are requested directly by -p ma:ca:dd:re:ss or -d devicename. This is how it already works for official devices with known names.

This is both a workaround for bug in noble-winrt and also way to force connection to device with missing advertising info.

This was the most straightforward solution. Feel free to cleanup/fix poor javascript coding.

@gfwilliams
Copy link
Member

Thanks! Sorry for the delay - I was wondering whether to add some comments the code but I've run out of time so just merging now.

@gfwilliams gfwilliams merged commit 09189ec into espruino:master May 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants