New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Suggestion] Code organization, folder per app #46
Comments
Thanks - yes, that could make sense. To be honest even with that it's going to get pretty hard to navigate, so I'm open to other ideas as well. While having a single |
So for |
Except that you could no longer just test it out using GitHub pages :( While running a script seems fine to us, for a non-Node.js developer, installing Node.js then downloading and learning command-line git is quite a big learning curve. Another option is to use something like https://github.com/gfwilliams/ThinGallery (so basically just scrape the website using client-side code), but that's slow.
Yeah, I mean if you don't want to do a PR you can always host your own repo. I think there's definitely some possibility of allowing proper third party stuff later, but especially for beginners I think having one repo with some level of vetting is a good idea. |
Yes, I didn't think about non-Node.js users. What about leaving it like it is, you'll just edit Now I'm thinking how to combine good developer experience (with nice toolset, automated things and so on), but also keep it as simple as possible to add your own app. |
So how would moving to app folders look like.
|
I'd say have the folder based on the 7 character name - which means we then easily avoid name clashes. Probably not worth specifying the folder name in the JSON as it's just extra typing/opportunity for errors :) |
Fixed with #50 |
Reading espruino#1020 espruino#46 My understanding is that the requirement for a splitt apps.json solution is: - work seemlessly with github pages (no manually calling a script) - single (or at most a few) apps.json for the browser to load for the store so the store page is fast As the github pages already use jekyll to build the store page this can be solved by a minimal jekyll plugin. This is a proof of concept of that. If the concept is accepted in a next step, I will create the splitt files for mmore that just the two here.
Reading espruino#1020 espruino#46 My understanding is that the requirement for a splitt apps.json solution is: - work seemlessly with github pages (no manually calling a script) - single (or at most a few) apps.json for the browser to load for the store so the store page is fast As the github pages already use jekyll to build the store page this can be solved by a minimal jekyll plugin. This is a proof of concept of that. If the concept is accepted in a next step, I will create the splitt files for mmore that just the two here.
Would it make sense to have a folder per app, for better navigation in the source?
example:
apps/animals/animals.js
apps/animals/animals.json
The text was updated successfully, but these errors were encountered: