New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
messages: split library/gui/widget into separate apps #2297
Conversation
Thanks for this! Sorry about the app loader issue - the server had problems but it's fixed now.
The idea is that if an app says I reckon since there can only be one message gui, instead of That way it's faster and it's not using any memory at all until the gui is needed
I think these probably just need to provide a
Yes, this is a pain. I'd hit this with the messsageicons and left them in the I guess longer term maybe they need splitting up? |
Yeah, that makes sense. Definitely happy about getting rid of the
I like that better then what I've did now (setting a global
How about splitting up the menus, but still saving everything in |
Sounds great!
That sounds good to me - it'll be faster too as it seems pretty much every time a notification comes in we load the settings, so at least it's less files to load. If that's the case, let's just leave everything as-is for now to get the scope of this PR down? Then we can change that all later. Hopefully as far as this PR is concerned, once merged the Bangle will behave basically identically to before, just with more apps in the app loader. |
e8c3330
to
552df04
Compare
Are you happy with this now? I do see one reference to But otherwise it looks pretty good? |
I think I'm happy, just been too busy to test it/look it over properly (or I'd at least have found that |
552df04
to
ea21552
Compare
Ran into a bunch of bugs, but I think I fixed them all now. |
ea21552
to
28cbe61
Compare
28cbe61
to
2a506e7
Compare
Ok - just merged! Had to tweak a few things to ensure it actually auto-updated if you had normal messages on before, but it does appear to work for me as well :) |
Some issues I ran into:
messagegui
/messagewidget
, but the sanitycheck complains that the filenames don't match module names: