Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nRF5x: Only perform Write With Response where it's accepted #1059

Closed
gfwilliams opened this issue Feb 9, 2017 · 3 comments
Closed

nRF5x: Only perform Write With Response where it's accepted #1059

gfwilliams opened this issue Feb 9, 2017 · 3 comments
Labels
nRF5x

Comments

@gfwilliams
Copy link
Member

http://forum.espruino.com/conversations/298621/#comment13463259

In BLE_GATTC_EVT_CHAR_DISC_RSP, it's in p_chr->char_props.write_wo_resp / write

Then we need to write that to the JsVar for the characteristic, and then read that when we do a write in order to do the correct thing.
@gfwilliams
Copy link
Member Author

This might be fixed with 766a577 - needs testing on hardware that won't allow write with response

@Whizzard
Copy link

confirmed to work by two people in http://forum.espruino.com/conversations/298621/?offset=25

@gfwilliams
Copy link
Member Author

Great - thanks! Fixed then :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
nRF5x
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gfwilliams @Whizzard