Add optional notification of milestones reached to exstats and use it in run app #1545
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
myxor
reviewed
Mar 6, 2022
|
Thanks! I'm not too sure whether we should start loading loads of extra features into the exstats library (things like this could be in a separate Merging now :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I started this as just a test to try and get my feet wet with app development, but then it expanded a bit and I thought it could be useful so I wanted to open a PR for discussion, but understand if it needs some rework.
Basically, the
exstatsmodule can now be optionally instructed to emitnotifyevents whendist,step, ortimereach milestones set by the user (likedistgoing up 1000 m orstepgoing up 30 seconds). I set up therunapp to make use of this and it will allow the user to customize a differentBangle.buzz()pattern per notify event type. I think this could also be useful for pedometers and eventually apps likewohrmwhich want to know whenhrmhas gone outside of given bounds. I thought that it could be helpful to have that consolidated in theexstatsmodule rather than expecting each app to perform similar basic actions separately.