Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for __arm64__ (e.g. Apple Silicon) build #2177

Merged
merged 1 commit into from Apr 4, 2022

Conversation

opichals
Copy link
Contributor

@opichals opichals commented Apr 3, 2022

@opichals opichals changed the title Add support for __aarch64__ (Apple Silicon) build Add support for __arm64__ (e.g. Apple Silicon) build Apr 3, 2022
@gfwilliams
Copy link
Member

Great - thanks!

For the libs/tensorflow/third_party/gemmlowp/fixedpoint/fixedpoint.h change, do you think there's another way around that (like trying to undef GEMMLOWP_NEON in the Makefile or some header that's not part of Tensorflow?).

I can just imagine that unless this is a change that's also in upstream Tensorflow, next time we pull the latest Tensorflow version it'll overwrite this.

@opichals
Copy link
Contributor Author

opichals commented Apr 4, 2022

Added an empty ./libs/tensorflow/third_party/gemmlowp/fixedpoint/fixedpoint_neon.h which should not give you any trouble when upgrading later on.

@gfwilliams
Copy link
Member

Excellent - thank you for sorting this so quickly!

@gfwilliams gfwilliams merged commit a7bb8b7 into espruino:master Apr 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants