Update locales.js with en_NL and weatherClock #1021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added translations for English-Dutch
kmh -> km/h
km/h -> kmh (This did not fit in weather app)
Extra space to fix wind speed layout
Test
Extra space for layout fix
Add extra space to day of week
|
Thanks - looks good, but do you think you could change the weather app version? It should go |
kmh -> km/h for en_NL. km/h works fine with new WeatherClock v0.03
Weather Clock v0.02 -> v0.03
Add extra spaces for better layout, especially when locale for speedUnits is 'km/h' there was a text overlap.
Typo fix
|
lunctis-viribus
changed the title
Layout tweak. Make number of spaces dependent on length of locale speedUnits variable.
|
Perfect - thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added translations for English with Dutch units