- implemented Bangle.emit into android/boot ( remove direct call to m… #2274
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essage app ) - removed handleMessage code ( old emit into message app ) - added message.boot for attach to "message" event
|
Thanks - let's discuss this on https://forum.espruino.com/conversations/379866/#comment16762840 as there's already a long thread there |
|
I'm closing this PR because any solution that will be adopted will almost certainly not be this one. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@gfwilliams, I've implemented a demo of what I was trying to explain here:
it is a proof of concept (theoretically working).
I say theoretically working because on the basis of these modifications I implemented my "message" app and (for now) it seems to work without problems.
I think there are a few things that need to be changed:
It could be a solution? Are there any downsides I'm missing out on?