Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows Zadig update #54

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

OwenBrotherwood
Copy link

  • current Zadig advice "Delete the driver software for this device"
  • Zadig tries to create a system restoral point but this usually fails on my Windows 10 (but thanks Zadig for trying)

- current Zadig advice "Delete the driver software for this device"
- Zadig tries to create a system restoral point but this usually fails on my Windows 10 (but thanks Zadig for trying)
@sandeepmistry
Copy link
Collaborator

Hi @OwenBrotherwood,

Sorry, I'm a bit confused about this change.

Maybe you can share a screenshot of Zadig to clarify what you are referring to?

@OwenBrotherwood
Copy link
Author

OwenBrotherwood commented Feb 6, 2017

No Problem

I will try and obtain an Installation of Zadig where the installation fails in the 5 min timeout Zadig has for System restoral Point and find reference to the process in Zadig with how to remove Zadig, either by remove driver (remove driver files) or restoral of System Restoral Point
For the time being, here is a gif that shows an installation of Zadig that did not go wrong which can be some form of help for people who have never installed Zadig before

installation no problems with restoral point

Edit

"Delete the driver software for this device"

image

Edit

Generation of a System Restoral Point has a timeout of about 5 min and can fail
(I try and make a gif example of this but it is not allays possible to force the error in connection with documentation)

image

Edit

https://github.com/pbatard/libwdi/wiki/FAQ#Zadig

Edit
remove driver

@OwenBrotherwood
Copy link
Author

Documentation of what I am referring to is now in the #54 (comment)

@OwenBrotherwood
Copy link
Author

OwenBrotherwood commented Feb 6, 2017

Document for System Restoral Point creation that sometimes fails after 5 min.
Note that if there is no System Restoral Point, one has to follow the Uninstall driver (delete files) if one needs to return the system to usable if a mistake has been made or wish to use Windows drivers

https://github.com/pbatard/libwdi/blob/b18d73f9e9f46b04da51c293d85e0fa2d77c9254/libwdi/libwdi_dlg.c#L48-L69

Edit:
I have seen the L48-L69 a couple of times on my Windows 10 Laptop.
But today, no problems for the same Laptop: AND no System Restoral Point can be found either, so the best is to ensure the Uninstall driver (delete files) as this is usually ok

Edit:
In general, I allways make manual System Restoral Points to ensure that I can get back to a usable machine after testing various stuff.

@sandeepmistry
Copy link
Collaborator

So what's changes would you like to see in the read me?

To me the gif would make a nice addition. The uninstall guide, might be better suited for the wiki, and the read me can link to the wiki page.

@OwenBrotherwood
Copy link
Author

Sounds good with wiki and gif.
The background to my interest was my first usage Zadig caused me a restore: I got into problems.
The basic update and something in the wiki can help those that have come so far as Zadig and allow for pain free process.
Feel free to update the PR with what you feel is appropriate or I can alter the PR to the comments in #54 (comment)

@OwenBrotherwood
Copy link
Author

OwenBrotherwood commented Feb 13, 2017

dons https://www.youtube.com/watch?v=mL9B8wuEdms has all real info: my PR just has an addition that one should remove the drivers from the system


Edit:
Gathering more information from gyp and other sources, wiki page started with no content

@sandeepmistry
Copy link
Collaborator

my PR just has an addition that one should remove the drivers from the system

Sure, but it's not super clear, please update the PR accordingly or start a wiki page: https://github.com/sandeepmistry/node-bluetooth-hci-socket/wiki

rzr pushed a commit to abandonware/node-bluetooth-hci-socket that referenced this pull request Dec 14, 2018
- current Zadig advice "Delete the driver software for this device"
- Zadig tries to create a system restoral point but this usually fails on my Windows 10 (but thanks Zadig for trying)

Change-Id: I004df41220c7e12b7cf8b1f1f1a65aab701ffe32
Origin: https://github.com/noble/node-bluetooth-hci-socket/commit/1620b37d47b5168decffbf23c82d6c038a2d0e5a.patch
Forwarded: noble#54
@rzr
Copy link

rzr commented Dec 19, 2018

@rzr
Copy link

rzr commented Oct 1, 2021

May you forward your ticket to downstream version if relevant or confirm @abandonware version match your requirements here:

#123

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants