Improve font converter - allow font file selection #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's brilliant - thanks! Not sure if you spotted this but someone was asking just today about it! http://forum.espruino.com/conversations/370540/#comment16291655 I'll try and update the website later today with this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I wanted to use the Espruino Font Converter with a local .otf font file I had - and I realized it was possible to do it in Javascript by generating a Base64 data URL with
FileReader. Hope this is useful to others too :) Feel free to make any changes.PS: FYI I have noticed a separate bug - when using Google fonts, the font converter sometimes creates the font before the font loads, and you have to click "Go" again to regenerate it - but this only happens occasionally & I haven't tracked it down yet.