Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle non-JSON output in Puck/UART.eval #1

Closed
gfwilliams opened this issue Jan 7, 2020 · 2 comments
Closed

Handle non-JSON output in Puck/UART.eval #1

gfwilliams opened this issue Jan 7, 2020 · 2 comments

Comments

@gfwilliams
Copy link
Member

Mentioned at http://forum.espruino.com/conversations/341825/#comment15049147

Puck.eval('"\1"')

Basically Espruino doesn't stringify non-standard characters in a JSON compliant way - issue filed for it at espruino/Espruino#1737 - but we should maybe add a regex to make it work correctly with old firmwares that have the issue.
@gfwilliams
Copy link
Member Author

Fixed in Espruino with espruino/Espruino@1764905

@gfwilliams
Copy link
Member Author

Closing, as new Espruino versions are fine

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gfwilliams