Freeyourgadget/Gadgetbridge
Freeyourgadget
/
Gadgetbridge
56
815
Fork 336
Code Issues 760 Pull Requests 36 Releases Wiki Activity

How to handle initializeDevice failure? #2996

New Issue
Closed
opened 2022-12-12 16:51:44 +00:00 by gfwilliams · 9 comments
gfwilliams commented 2022-12-12 16:51:44 +00:00
Member
Copy Link

Before reporting a bug, please confirm the following:

  • I have read the wiki, and I didn't find a solution to my problem / an answer to my question.
  • I have searched the issues, and I didn't find a solution to my problem / an answer to my question.
  • If you upload an image or other content, please make sure you have read and understood the Codeberg Terms of Use

Where did you get Gadgetbridge from:

  • F-Droid
  • Gadgetbridge Nightly F-Droid repository
  • Bangle.js Gadgetbridge from the Play Store
  • I built it myself from source code (specify tag / commit)
  • I previously used Gadgetbridge from other sources and then updated to F-Droid version

Your Gadgetbridge version is:

0.71.3-banglejs (this has been an issue since Bangle.js got added though)

Your issue is:

Under some circumstances a device's initializeDevice can be called without the relevant Bluetooth characteristics having been found. In this case, getCharacteristic returns null and then TransactionBuilder write calls to that all fail.

It's quite rare, and it's possible it's due to an Android implementation issue, or maybe even just radio interference while the characteristics are being fetched.

(Also AbstractBTLEDeviceSupport.performInitialized can call it, seemingly without ever getting the services)

But the repurcussions are bad: In Bangle.js, initializeDevice still runs through, although a bunch of stuff fails. The device stays connected, but nothing works, and eventually Bangle.js is buffering up data to send and the watch just hangs, waiting for Gadgetbridge to enable notifications so it can send its data.

I checked and I can't find any other devices that check if getCharacteristic returns non-null, so I think this must apply to other watches too.

So, what I'd like to do is when getCharacteristic returns null in initializeDevice, just ask Gadgetbridge to disconnect and retry the connection which should fix it.

Can I literally just add:

        if (rxCharacteristic==null || txCharacteristic==null) {
            LOG.warn("Unable to get characteristics, forcing a disconnect.");
            GBApplication.deviceService(gbDevice).disconnect();
            return builder;
        }

Or it seems this will break stuff? It seems like AbstractBTLEDeviceSupport may be expecting that initializeDevice will always complete. Is there a better way? Can mQueue.disconnect() be called? I'm not sure it's ever used.

I also wonder if the fix for this could maybe help with #2880

Log of this happening is attached, the issue happens around 11:10:22.931.

Sorry for the ACTION_DEVICE_CHANGED spam messages - I just fixed this.

Expected

initializeDevice
20:49:12.085 [Binder:3980_A] DEBUG n.f.g.s.d.b.BangleJSDeviceSupport - discovered unsupported service: Generic Access: 00001800-0000-1000-8000-00805f9b34fb
20:49:12.086 [Binder:3980_A] DEBUG n.f.g.s.d.b.BangleJSDeviceSupport - discovered unsupported service: Generic Attribute: 00001801-0000-1000-8000-00805f9b34fb
20:49:12.086 [Binder:3980_A] DEBUG n.f.g.s.d.b.BangleJSDeviceSupport - discovered supported service: Unknown Service: 6e400001-b5a3-f393-e0a9-e50e24dcca9e
20:49:12.086 [Binder:3980_A] INFO  n.f.g.s.d.b.BangleJSDeviceSupport -     characteristic: Unknown Characteristic: 6e400002-b5a3-f393-e0a9-e50e24dcca9e
20:49:12.086 [Binder:3980_A] INFO  n.f.g.s.d.b.BangleJSDeviceSupport -     characteristic: Unknown Characteristic: 6e400003-b5a3-f393-e0a9-e50e24dcca9e
20:49:12.086 [Binder:3980_A] INFO  n.f.g.s.d.b.BangleJSDeviceSupport - Initializing
20:49:12.087 [Binder:3980_A] INFO  n.f.g.s.d.b.BangleJSDeviceSupport - UART TX:  .....
20:49:12.087 [Binder:3980_A] INFO  n.f.g.s.d.b.BangleJSDeviceSupport - Initialization Done

When it occasionally breaks

11:10:22.931 [Binder:3980_3] DEBUG n.f.g.s.d.b.BangleJSDeviceSupport - discovered unsupported service: Generic Access: 00001800-0000-1000-8000-00805f9b34fb
11:10:22.933 [Binder:3980_3] INFO  n.f.g.s.d.b.BangleJSDeviceSupport - Initializing
11:10:22.934 [Binder:3980_3] WARN  n.f.g.s.b.TransactionBuilder - Unable to notify characteristic: null
11:10:22.934 [Binder:3980_3] INFO  n.f.g.s.d.b.BangleJSDeviceSupport - UART TX:  ...
11:10:22.934 [Binder:3980_3] WARN  n.f.g.s.b.TransactionBuilder - Unable to write characteristic: null
...
11:10:22.937 [Binder:3980_3] INFO  n.f.g.s.d.b.BangleJSDeviceSupport - Initialization Done
...
# and whenever it writes we get: TransactionBuilder - Unable to write characteristic: null

Your wearable device is:

Bangle.js

Your Android version/manufacturer flavor is:

Android 11 (MIUI 12.5.8)

But it happens on many other phones too.

#### Before reporting a bug, please confirm the following: - [x] I have read the [wiki](https://codeberg.org/Freeyourgadget/Gadgetbridge/wiki), and I didn't find a solution to my problem / an answer to my question. - [x] I have searched the [issues](https://codeberg.org/Freeyourgadget/Gadgetbridge/issues), and I didn't find a solution to my problem / an answer to my question. - [x] If you upload an image or other content, please make sure you have read and understood the [Codeberg Terms of Use](https://codeberg.org/Codeberg/org/src/branch/main/TermsOfUse.md) ### Where did you get Gadgetbridge from: * [x] F-Droid * [x] Gadgetbridge Nightly F-Droid repository * [x] Bangle.js Gadgetbridge from the Play Store * [ ] I built it myself from source code (specify tag / commit) * [ ] I previously used Gadgetbridge from other sources and then updated to F-Droid version ### Your Gadgetbridge version is: 0.71.3-banglejs (this has been an issue since Bangle.js got added though) #### Your issue is: Under some circumstances a device's `initializeDevice` can be called without the relevant Bluetooth characteristics having been found. In this case, getCharacteristic returns `null` and then `TransactionBuilder` `write` calls to that all fail. It's quite rare, and it's possible it's due to an Android implementation issue, or maybe even just radio interference while the characteristics are being fetched. (Also AbstractBTLEDeviceSupport.performInitialized can call it, seemingly without ever getting the services) But the repurcussions are bad: In Bangle.js, initializeDevice still runs through, although a bunch of stuff fails. The device stays connected, but nothing works, and eventually Bangle.js is buffering up data to send and the watch just hangs, waiting for Gadgetbridge to enable notifications so it can send its data. I checked and I can't find any other devices that check if getCharacteristic returns non-null, so I think this must apply to other watches too. So, what I'd like to do is when getCharacteristic returns null in initializeDevice, just ask Gadgetbridge to disconnect and retry the connection which should fix it. Can I literally just add: ``` if (rxCharacteristic==null || txCharacteristic==null) { LOG.warn("Unable to get characteristics, forcing a disconnect."); GBApplication.deviceService(gbDevice).disconnect(); return builder; } ``` Or it seems this will break stuff? It seems like AbstractBTLEDeviceSupport may be expecting that initializeDevice will always complete. Is there a better way? Can `mQueue.disconnect()` be called? I'm not sure it's ever used. I also wonder if the fix for this could maybe help with https://codeberg.org/Freeyourgadget/Gadgetbridge/issues/2880 Log of this happening is attached, the issue happens around 11:10:22.931. Sorry for the ACTION_DEVICE_CHANGED spam messages - I just fixed this. **Expected** ``` initializeDevice 20:49:12.085 [Binder:3980_A] DEBUG n.f.g.s.d.b.BangleJSDeviceSupport - discovered unsupported service: Generic Access: 00001800-0000-1000-8000-00805f9b34fb 20:49:12.086 [Binder:3980_A] DEBUG n.f.g.s.d.b.BangleJSDeviceSupport - discovered unsupported service: Generic Attribute: 00001801-0000-1000-8000-00805f9b34fb 20:49:12.086 [Binder:3980_A] DEBUG n.f.g.s.d.b.BangleJSDeviceSupport - discovered supported service: Unknown Service: 6e400001-b5a3-f393-e0a9-e50e24dcca9e 20:49:12.086 [Binder:3980_A] INFO n.f.g.s.d.b.BangleJSDeviceSupport - characteristic: Unknown Characteristic: 6e400002-b5a3-f393-e0a9-e50e24dcca9e 20:49:12.086 [Binder:3980_A] INFO n.f.g.s.d.b.BangleJSDeviceSupport - characteristic: Unknown Characteristic: 6e400003-b5a3-f393-e0a9-e50e24dcca9e 20:49:12.086 [Binder:3980_A] INFO n.f.g.s.d.b.BangleJSDeviceSupport - Initializing 20:49:12.087 [Binder:3980_A] INFO n.f.g.s.d.b.BangleJSDeviceSupport - UART TX: ..... 20:49:12.087 [Binder:3980_A] INFO n.f.g.s.d.b.BangleJSDeviceSupport - Initialization Done ``` **When it occasionally breaks** ``` 11:10:22.931 [Binder:3980_3] DEBUG n.f.g.s.d.b.BangleJSDeviceSupport - discovered unsupported service: Generic Access: 00001800-0000-1000-8000-00805f9b34fb 11:10:22.933 [Binder:3980_3] INFO n.f.g.s.d.b.BangleJSDeviceSupport - Initializing 11:10:22.934 [Binder:3980_3] WARN n.f.g.s.b.TransactionBuilder - Unable to notify characteristic: null 11:10:22.934 [Binder:3980_3] INFO n.f.g.s.d.b.BangleJSDeviceSupport - UART TX: ... 11:10:22.934 [Binder:3980_3] WARN n.f.g.s.b.TransactionBuilder - Unable to write characteristic: null ... 11:10:22.937 [Binder:3980_3] INFO n.f.g.s.d.b.BangleJSDeviceSupport - Initialization Done ... # and whenever it writes we get: TransactionBuilder - Unable to write characteristic: null ``` #### Your wearable device is: Bangle.js #### Your Android version/manufacturer flavor is: Android 11 (MIUI 12.5.8) But it happens on many other phones too.
9d2cfe37d2295f6a3f015bfbc9773501d4637ac3.log
1.5 MiB
gfwilliams commented 2023-07-12 10:04:52 +00:00
Author
Member
Copy Link

Hi - does anyone have any thoughts on this? @joserebelo ?

I realise the issue posted was a bit long, but basically:

How do I force a device reconnect from within the initializeDevice function?

Hi - does anyone have any thoughts on this? @joserebelo ? I realise the issue posted was a bit long, but basically: **How do I force a device reconnect from within the `initializeDevice` function?**
joserebelo commented 2023-07-12 20:00:13 +00:00
Member
Copy Link

@gfwilliams sorry, I missed this issue.

I think this is actually not as rare as you think. I'm fairily sure this is what's causing reconnects to fail on my Amazfit GTR 4, and probably a lot of other devices - the symptoms are similar:

  • Connection is lost
  • Connection is re-established
  • Enabling the notifications on characteristics fails (they are null)
  • We write the initialization payload, but never get a reply because there are no notifications, so it gets stuck "Reconnecting" permanently.
Logs here 
12:24:20.056 [binder:16285_3] DEBUG n.f.g.s.b.BtLEQueue - connection state change, newState: 0 (success)
12:24:20.057 [binder:16285_3] INFO  n.f.g.s.b.BtLEQueue - Disconnected from GATT server.
12:24:20.058 [binder:16285_3] DEBUG n.f.g.s.b.BtLEQueue - handleDisconnected: 0
12:24:20.058 [binder:16285_3] DEBUG n.f.g.s.b.BtLEQueue - internal gatt callback set to null
12:24:20.058 [binder:16285_3] DEBUG n.f.g.s.b.BtLEQueue - new device connection state: NOT_CONNECTED
12:24:20.059 [binder:16285_3] INFO  n.f.g.s.b.BtLEQueue - Enabling automatic ble reconnect...
12:24:20.066 [binder:16285_3] DEBUG n.f.g.s.b.BtLEQueue - new device connection state: WAITING_FOR_RECONNECT
12:24:20.121 [main] INFO  n.f.g.s.DeviceCommunicationService - Setting broadcast receivers to: true
12:24:20.142 [main] INFO  n.f.g.s.DeviceCommunicationService - Setting broadcast receivers to: true
12:24:20.152 [main] INFO  n.f.g.s.r.AutoConnectIntervalReceiver - scheduling reconnect in 8 seconds
12:24:20.159 [main] INFO  n.f.g.s.r.AutoConnectIntervalReceiver - scheduling reconnect in 16 seconds
12:24:34.632 [binder:16285_7] DEBUG n.f.g.s.b.BtLEQueue - connection state change, newState: 2 (success)
12:24:34.633 [binder:16285_7] INFO  n.f.g.s.b.BtLEQueue - Connected to GATT server.
12:24:34.633 [binder:16285_7] DEBUG n.f.g.s.b.BtLEQueue - new device connection state: CONNECTED
12:24:34.634 [binder:16285_7] INFO  n.f.g.s.b.BtLEQueue - Using cached services, skipping discovery
12:24:34.634 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered supported service: Generic Attribute: 00001801-0000-1000-8000-00805f9b34fb
12:24:34.634 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Service Changed: 00002a05-0000-1000-8000-00805f9b34fb
12:24:34.635 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered supported service: Generic Access: 00001800-0000-1000-8000-00805f9b34fb
12:24:34.635 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Device Name: 00002a00-0000-1000-8000-00805f9b34fb
12:24:34.635 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Appearance: 00002a01-0000-1000-8000-00805f9b34fb
12:24:34.635 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Peripheral Preferred Connection Parameters: 00002a04-0000-1000-8000-00805f9b34fb
12:24:34.636 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Unknown Characteristic: 00002aa6-0000-1000-8000-00805f9b34fb
12:24:34.636 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered supported service: Alert Notification Service: 00001811-0000-1000-8000-00805f9b34fb
12:24:34.636 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: New Alert: 00002a46-0000-1000-8000-00805f9b34fb
12:24:34.636 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered supported service: Device Information: 0000180a-0000-1000-8000-00805f9b34fb
12:24:34.636 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: System ID: 00002a23-0000-1000-8000-00805f9b34fb
12:24:34.637 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Serial Number String: 00002a25-0000-1000-8000-00805f9b34fb
12:24:34.637 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Hardware Revision String: 00002a27-0000-1000-8000-00805f9b34fb
12:24:34.637 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Software Revision String: 00002a28-0000-1000-8000-00805f9b34fb
12:24:34.637 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: PnP ID: 00002a50-0000-1000-8000-00805f9b34fb
12:24:34.637 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered supported service: Unknown Service: 0000fee0-0000-1000-8000-00805f9b34fb
12:24:34.637 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Current Time: 00002a2b-0000-1000-8000-00805f9b34fb
12:24:34.638 [main] INFO  n.f.g.e.BluetoothConnectReceiver - connection attempt detected from XX:XX:XX:XX:XX:XX(Amazfit GTR 4)
12:24:34.638 [main] INFO  n.f.g.e.BluetoothConnectReceiver - Will re-connect to XX:XX:XX:XX:XX:XX(Amazfit GTR 4)
12:24:34.638 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Unknown Characteristic: 00000016-0000-3512-2118-0009af100700
12:24:34.642 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Unknown Characteristic: 00000017-0000-3512-2118-0009af100700
12:24:34.649 [main] INFO  n.f.g.s.DeviceCommunicationService - Setting broadcast receivers to: true
12:24:34.652 [main] DEBUG n.f.g.s.DeviceCommunicationService - Service startcommand: nodomain.freeyourgadget.gadgetbridge.devices.action.connect
12:24:34.643 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Unknown Characteristic: 00000001-0000-3512-2118-0009af100700
12:24:34.654 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Unknown Characteristic: 00000002-0000-3512-2118-0009af100700
12:24:34.654 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Unknown Characteristic: 00000004-0000-3512-2118-0009af100700
12:24:34.655 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Unknown Characteristic: 00000005-0000-3512-2118-0009af100700
12:24:34.655 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Unknown Characteristic: 00000006-0000-3512-2118-0009af100700
12:24:34.656 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered supported service: (Propr: Xiaomi Weight Service): 00001530-0000-3512-2118-0009af100700
12:24:34.656 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Unknown Characteristic: 00001531-0000-3512-2118-0009af100700
12:24:34.656 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Unknown Characteristic: 00001532-0000-3512-2118-0009af100700
12:24:34.656 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered supported service: Heart Rate: 0000180d-0000-1000-8000-00805f9b34fb
12:24:34.656 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Heart Rate Measurement: 00002a37-0000-1000-8000-00805f9b34fb
12:24:34.657 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered supported service: Unknown Service: 0000fee1-0000-1000-8000-00805f9b34fb
12:24:34.657 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Unknown Characteristic: 0000fedd-0000-1000-8000-00805f9b34fb
12:24:34.657 [binder:16285_7] INFO  n.f.g.s.d.h.Huami2021Support -     characteristic: Unknown Characteristic: 0000fede-0000-1000-8000-00805f9b34fb
12:24:34.657 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered unsupported service: Unknown Service: 00003802-0000-1000-8000-00805f9b34fb
12:24:34.658 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered unsupported service: Unknown Service: cc353442-be58-4ea2-876e-11d8d6976366
12:24:34.658 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered unsupported service: Human Interface Device: 00001812-0000-1000-8000-00805f9b34fb
12:24:34.658 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered unsupported service: Battery Service: 0000180f-0000-1000-8000-00805f9b34fb
12:24:34.663 [binder:16285_7] WARN  n.f.g.s.b.TransactionBuilder - Unable to notify characteristic: null
12:24:34.664 [binder:16285_7] WARN  n.f.g.s.b.TransactionBuilder - Unable to notify characteristic: null
12:24:34.664 [binder:16285_7] WARN  n.f.g.s.b.TransactionBuilder - Unable to notify characteristic: null
12:24:34.748 [binder:16285_7] DEBUG n.f.g.s.b.BtLEQueue - about to add: 12:24:34: Transaction task: Initializing device with 3 actions
12:24:34.751 [Gadgetbridge GATT Dispatcher] DEBUG n.f.g.s.b.BtLEQueue - About to run action: July 12, 12:24: NotifyAction on characteristic: 00000017-0000-3512-2118-0009af100700
12:24:34.766 [Gadgetbridge GATT Dispatcher] DEBUG n.f.g.s.b.a.NotifyAction - use NOTIFICATION
12:24:34.856 [binder:16285_7] DEBUG n.f.g.s.b.BtLEQueue - descriptor write: 00002902-0000-1000-8000-00805f9b34fb (success)
12:24:34.859 [Gadgetbridge GATT Dispatcher] DEBUG n.f.g.s.b.BtLEQueue - About to run action: July 12, 12:24: SetDeviceStateAction to INITIALIZING
12:24:34.866 [main] INFO  n.f.g.s.DeviceCommunicationService - Setting broadcast receivers to: true
12:24:34.868 [Gadgetbridge GATT Dispatcher] DEBUG n.f.g.s.b.BtLEQueue - About to run action: July 12, 12:24: WriteAction on characteristic: 00000016-0000-3512-2118-0009af100700
12:24:34.882 [Gadgetbridge GATT Dispatcher] DEBUG n.f.g.s.b.a.WriteAction - writing to characteristic: 00000016-0000-3512-2118-0009af100700: 0x...
12:24:34.916 [binder:16285_7] DEBUG n.f.g.s.b.BtLEQueue - characteristic write: 00000016-0000-3512-2118-0009af100700 (success)

... does not recover until a manual disconnect and reconnect

Fixing this would probably fix reconnects across all devices.

As for your question - I have no idea. This is actually one of the few areas of Gadgetbridge in which I do not yet have a lot of experience, I have to take some time in the weekend to dive into the code. We will probably have to run a few tests and see how it behaves.

I do get this issue multiple times per day, so once we have some changes that we want to test I can probably just use them for a while.

@gfwilliams sorry, I missed this issue. I think this is actually not as rare as you think. I'm fairily sure this is what's causing reconnects to fail on my Amazfit GTR 4, and probably a lot of other devices - the symptoms are similar: - Connection is lost - Connection is re-established - Enabling the notifications on characteristics fails (they are null) - We write the initialization payload, but never get a reply because there are no notifications, so it gets stuck "Reconnecting" permanently. <details> <summary>Logs here</summary> ``` 12:24:20.056 [binder:16285_3] DEBUG n.f.g.s.b.BtLEQueue - connection state change, newState: 0 (success) 12:24:20.057 [binder:16285_3] INFO n.f.g.s.b.BtLEQueue - Disconnected from GATT server. 12:24:20.058 [binder:16285_3] DEBUG n.f.g.s.b.BtLEQueue - handleDisconnected: 0 12:24:20.058 [binder:16285_3] DEBUG n.f.g.s.b.BtLEQueue - internal gatt callback set to null 12:24:20.058 [binder:16285_3] DEBUG n.f.g.s.b.BtLEQueue - new device connection state: NOT_CONNECTED 12:24:20.059 [binder:16285_3] INFO n.f.g.s.b.BtLEQueue - Enabling automatic ble reconnect... 12:24:20.066 [binder:16285_3] DEBUG n.f.g.s.b.BtLEQueue - new device connection state: WAITING_FOR_RECONNECT 12:24:20.121 [main] INFO n.f.g.s.DeviceCommunicationService - Setting broadcast receivers to: true 12:24:20.142 [main] INFO n.f.g.s.DeviceCommunicationService - Setting broadcast receivers to: true 12:24:20.152 [main] INFO n.f.g.s.r.AutoConnectIntervalReceiver - scheduling reconnect in 8 seconds 12:24:20.159 [main] INFO n.f.g.s.r.AutoConnectIntervalReceiver - scheduling reconnect in 16 seconds 12:24:34.632 [binder:16285_7] DEBUG n.f.g.s.b.BtLEQueue - connection state change, newState: 2 (success) 12:24:34.633 [binder:16285_7] INFO n.f.g.s.b.BtLEQueue - Connected to GATT server. 12:24:34.633 [binder:16285_7] DEBUG n.f.g.s.b.BtLEQueue - new device connection state: CONNECTED 12:24:34.634 [binder:16285_7] INFO n.f.g.s.b.BtLEQueue - Using cached services, skipping discovery 12:24:34.634 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered supported service: Generic Attribute: 00001801-0000-1000-8000-00805f9b34fb 12:24:34.634 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Service Changed: 00002a05-0000-1000-8000-00805f9b34fb 12:24:34.635 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered supported service: Generic Access: 00001800-0000-1000-8000-00805f9b34fb 12:24:34.635 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Device Name: 00002a00-0000-1000-8000-00805f9b34fb 12:24:34.635 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Appearance: 00002a01-0000-1000-8000-00805f9b34fb 12:24:34.635 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Peripheral Preferred Connection Parameters: 00002a04-0000-1000-8000-00805f9b34fb 12:24:34.636 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Unknown Characteristic: 00002aa6-0000-1000-8000-00805f9b34fb 12:24:34.636 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered supported service: Alert Notification Service: 00001811-0000-1000-8000-00805f9b34fb 12:24:34.636 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: New Alert: 00002a46-0000-1000-8000-00805f9b34fb 12:24:34.636 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered supported service: Device Information: 0000180a-0000-1000-8000-00805f9b34fb 12:24:34.636 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: System ID: 00002a23-0000-1000-8000-00805f9b34fb 12:24:34.637 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Serial Number String: 00002a25-0000-1000-8000-00805f9b34fb 12:24:34.637 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Hardware Revision String: 00002a27-0000-1000-8000-00805f9b34fb 12:24:34.637 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Software Revision String: 00002a28-0000-1000-8000-00805f9b34fb 12:24:34.637 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: PnP ID: 00002a50-0000-1000-8000-00805f9b34fb 12:24:34.637 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered supported service: Unknown Service: 0000fee0-0000-1000-8000-00805f9b34fb 12:24:34.637 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Current Time: 00002a2b-0000-1000-8000-00805f9b34fb 12:24:34.638 [main] INFO n.f.g.e.BluetoothConnectReceiver - connection attempt detected from XX:XX:XX:XX:XX:XX(Amazfit GTR 4) 12:24:34.638 [main] INFO n.f.g.e.BluetoothConnectReceiver - Will re-connect to XX:XX:XX:XX:XX:XX(Amazfit GTR 4) 12:24:34.638 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Unknown Characteristic: 00000016-0000-3512-2118-0009af100700 12:24:34.642 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Unknown Characteristic: 00000017-0000-3512-2118-0009af100700 12:24:34.649 [main] INFO n.f.g.s.DeviceCommunicationService - Setting broadcast receivers to: true 12:24:34.652 [main] DEBUG n.f.g.s.DeviceCommunicationService - Service startcommand: nodomain.freeyourgadget.gadgetbridge.devices.action.connect 12:24:34.643 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Unknown Characteristic: 00000001-0000-3512-2118-0009af100700 12:24:34.654 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Unknown Characteristic: 00000002-0000-3512-2118-0009af100700 12:24:34.654 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Unknown Characteristic: 00000004-0000-3512-2118-0009af100700 12:24:34.655 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Unknown Characteristic: 00000005-0000-3512-2118-0009af100700 12:24:34.655 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Unknown Characteristic: 00000006-0000-3512-2118-0009af100700 12:24:34.656 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered supported service: (Propr: Xiaomi Weight Service): 00001530-0000-3512-2118-0009af100700 12:24:34.656 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Unknown Characteristic: 00001531-0000-3512-2118-0009af100700 12:24:34.656 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Unknown Characteristic: 00001532-0000-3512-2118-0009af100700 12:24:34.656 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered supported service: Heart Rate: 0000180d-0000-1000-8000-00805f9b34fb 12:24:34.656 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Heart Rate Measurement: 00002a37-0000-1000-8000-00805f9b34fb 12:24:34.657 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered supported service: Unknown Service: 0000fee1-0000-1000-8000-00805f9b34fb 12:24:34.657 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Unknown Characteristic: 0000fedd-0000-1000-8000-00805f9b34fb 12:24:34.657 [binder:16285_7] INFO n.f.g.s.d.h.Huami2021Support - characteristic: Unknown Characteristic: 0000fede-0000-1000-8000-00805f9b34fb 12:24:34.657 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered unsupported service: Unknown Service: 00003802-0000-1000-8000-00805f9b34fb 12:24:34.658 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered unsupported service: Unknown Service: cc353442-be58-4ea2-876e-11d8d6976366 12:24:34.658 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered unsupported service: Human Interface Device: 00001812-0000-1000-8000-00805f9b34fb 12:24:34.658 [binder:16285_7] DEBUG n.f.g.s.d.h.Huami2021Support - discovered unsupported service: Battery Service: 0000180f-0000-1000-8000-00805f9b34fb 12:24:34.663 [binder:16285_7] WARN n.f.g.s.b.TransactionBuilder - Unable to notify characteristic: null 12:24:34.664 [binder:16285_7] WARN n.f.g.s.b.TransactionBuilder - Unable to notify characteristic: null 12:24:34.664 [binder:16285_7] WARN n.f.g.s.b.TransactionBuilder - Unable to notify characteristic: null 12:24:34.748 [binder:16285_7] DEBUG n.f.g.s.b.BtLEQueue - about to add: 12:24:34: Transaction task: Initializing device with 3 actions 12:24:34.751 [Gadgetbridge GATT Dispatcher] DEBUG n.f.g.s.b.BtLEQueue - About to run action: July 12, 12:24: NotifyAction on characteristic: 00000017-0000-3512-2118-0009af100700 12:24:34.766 [Gadgetbridge GATT Dispatcher] DEBUG n.f.g.s.b.a.NotifyAction - use NOTIFICATION 12:24:34.856 [binder:16285_7] DEBUG n.f.g.s.b.BtLEQueue - descriptor write: 00002902-0000-1000-8000-00805f9b34fb (success) 12:24:34.859 [Gadgetbridge GATT Dispatcher] DEBUG n.f.g.s.b.BtLEQueue - About to run action: July 12, 12:24: SetDeviceStateAction to INITIALIZING 12:24:34.866 [main] INFO n.f.g.s.DeviceCommunicationService - Setting broadcast receivers to: true 12:24:34.868 [Gadgetbridge GATT Dispatcher] DEBUG n.f.g.s.b.BtLEQueue - About to run action: July 12, 12:24: WriteAction on characteristic: 00000016-0000-3512-2118-0009af100700 12:24:34.882 [Gadgetbridge GATT Dispatcher] DEBUG n.f.g.s.b.a.WriteAction - writing to characteristic: 00000016-0000-3512-2118-0009af100700: 0x... 12:24:34.916 [binder:16285_7] DEBUG n.f.g.s.b.BtLEQueue - characteristic write: 00000016-0000-3512-2118-0009af100700 (success) ... does not recover until a manual disconnect and reconnect ``` </details> Fixing this would probably fix reconnects across all devices. As for your question - I have no idea. This is actually one of the few areas of Gadgetbridge in which I do not yet have a lot of experience, I have to take some time in the weekend to dive into the code. We will probably have to run a few tests and see how it behaves. I do get this issue multiple times per day, so once we have some changes that we want to test I can probably just use them for a while.
gfwilliams commented 2023-07-13 10:21:26 +00:00
Author
Member
Copy Link

No offense, but it's great news that it's affecting you! I had it happen once or twice but it hasn't happened in months for me (although it is affecting others).

We'd have to look but if getCharacteristic was always used in such a way that it shouldn't give a non-null response, we could add a check in there and it'd fix all watches.

Either that or for each watch we just check that the characteristics it cares about are non-null, and if they are we force a reconnect. I guess that could be safer.

No offense, but it's great news that it's affecting you! I had it happen once or twice but it hasn't happened in months for me (although it is affecting others). We'd have to look but if `getCharacteristic` was always used in such a way that it shouldn't give a non-null response, we could add a check in there and it'd fix all watches. Either that or for each watch we just check that the characteristics it cares about are non-null, and if they are we force a reconnect. I guess that could be safer.
johannesk commented 2023-07-20 06:39:28 +00:00
Contributor
Copy Link

I have a Casio GW-B5600 and all the characteristics are null on the first connectino (when pairing), but I did not observe this on any later connection.

For me the following workaround works: 2d0cd54136

The workaronud consists of calling mQueue.disconnect() followed by connect().

I have a Casio GW-B5600 and all the characteristics are null on the first connectino (when pairing), but I did not observe this on any later connection. For me the following workaround works: https://codeberg.org/johannesk/Gadgetbridge/commit/2d0cd54136977a3024c03353712788d95fbda30d The workaronud consists of calling `mQueue.disconnect()` followed by `connect()`.
joserebelo commented 2023-07-22 13:44:41 +00:00
Member
Copy Link

@gfwilliams @johannesk I was experimenting with my Amazfit GTR 4, and managed to make the issue somewhat reproducible by turning bluetooth off and on on the watch.

Instead of disconnecting and reconnecting, I set the device as waiting for reconnect, and let the reconnection mechanism trigger the reconnect at a slightly later time - this includes a back-off mechanism, which does not exist when calling disconnect and connect - which might actually enter a loop in quick succession?

This seems to have fixed the issue on my side, I will now run it for a while to check if it keeps reconnecting without issues through normal usage.

See #3219

@gfwilliams @johannesk I was experimenting with my Amazfit GTR 4, and managed to make the issue somewhat reproducible by turning bluetooth off and on on the watch. Instead of disconnecting and reconnecting, I set the device as waiting for reconnect, and let the reconnection mechanism trigger the reconnect at a slightly later time - this includes a back-off mechanism, which does not exist when calling disconnect and connect - which might actually enter a loop in quick succession? This seems to have fixed the issue on my side, I will now run it for a while to check if it keeps reconnecting without issues through normal usage. See #3219
joserebelo added the
pairing/connecting
 label 2023-07-22 13:46:06 +00:00
gfwilliams commented 2023-07-24 09:20:00 +00:00
Author
Member
Copy Link

I set the device as waiting for reconnect, and let the reconnection mechanism trigger the reconnect at a slightly later time - this includes a back-off mechanism

That sounds perfect! Exactly what I was after - do you think you could add it to the Bangle.js build as well, or shall I do that?

Just looking at #3219 you call builder.add(new SetDeviceStateAction(getDevice(), State.WAITING_FOR_RECONNECT, getContext())); if either of the characteristics is null?

That doesn't actually cause a disconnect though? Or does WAITING_FOR_RECONNECT automatically disconnect if the watch was connected?

> I set the device as waiting for reconnect, and let the reconnection mechanism trigger the reconnect at a slightly later time - this includes a back-off mechanism That sounds perfect! Exactly what I was after - do you think you could add it to the Bangle.js build as well, or shall I do that? Just looking at https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/3219 you call `builder.add(new SetDeviceStateAction(getDevice(), State.WAITING_FOR_RECONNECT, getContext()));` if either of the characteristics is null? That doesn't actually cause a disconnect though? Or does `WAITING_FOR_RECONNECT` automatically disconnect if the watch was connected?
joserebelo commented 2023-07-24 17:00:20 +00:00
Member
Copy Link

It seems to only trigger a connect, without disconnecting first: a02a6cba14/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/receivers/AutoConnectIntervalReceiver.java (L87)

I can add it to the Bangle if you want, just need to try and reproduce the issue there first, maybe by toggling bluetooth on the watch too.

It seems to only trigger a connect, without disconnecting first: https://codeberg.org/Freeyourgadget/Gadgetbridge/src/commit/a02a6cba148989c4cbfa6480826a6c048bffe9ab/app/src/main/java/nodomain/freeyourgadget/gadgetbridge/service/receivers/AutoConnectIntervalReceiver.java#L87 I can add it to the Bangle if you want, just need to try and reproduce the issue there first, maybe by toggling bluetooth on the watch too.
gfwilliams commented 2023-07-25 09:41:24 +00:00
Author
Member
Copy Link

Thanks for checking that! Maybe wait a bit then - I think at least for Bangle.js it would probably help to force a disconnect first.

Maybe if this is a common thing we should have a method in AbstractBTLEDeviceSupport.java for it?

Thanks for checking that! Maybe wait a bit then - I think at least for Bangle.js it would probably help to force a disconnect first. Maybe if this is a common thing we should have a method in AbstractBTLEDeviceSupport.java for it?
gfwilliams commented 2023-11-20 11:02:41 +00:00
Author
Member
Copy Link

At least one user is reporting problems still: https://forum.espruino.com/conversations/378217/?offset=25#comment17199563

So I just pushed a potential fix for this that copies that line - let's hope it has some effect.

At least one user is reporting problems still: https://forum.espruino.com/conversations/378217/?offset=25#comment17199563 So I just pushed a potential fix for this that copies that line - let's hope it has some effect.
Sign in to join this conversation.
No Branch/Tag Specified
Branches Tags
master
jr-garmin-experiments
jr-garmin
garmin-dg-refactor
device-pavlok
welcome_flow
device-cycling-sensor
jr-gradle-8
ui-improvements
jr-bangle-reply
jr-bangle-prefs
ble-scan-before-reconnect-old
pixoo-experiments
jr-mijia-lywsd
jr-xiaomi-activity-hr
jr-zepp-os-alexa
jr-lint-fixes
jr-internet-helper
filter_ci
nightly-branch
release-0.75.x
osmand-experiments
bicycle_sensor
supercars_blinking
test_link
test_debug_release
debug-branch
test_own_image
fix_logger_again
streaks
huami-sms-reply
RemoveMibandGlobalPreferences
SystemEvents
combined
openTracksObserver-debug
cycling_sensor
multi-device-support-clean-2
miband6-alipay
fossil-hr-activity-fix
fossil-q-hr-html
dakhnod/fix-notification-removed
dakhnod/beautify-device-information
Lightwars/TurnClocksForward
andyboeh/ble_reconnect_scan
ildar/patches/circleci
mvallerie/custom_menu_miband2
christian-n/master
lucasgaley/master
Dikay900/steps_diagram
comradekingu/patch-3
elagin/sleep_values_on_chart
boun/runnerup
thePanz/add-raw-data-support
plugdio/master
atx/master
Vebryn/csv-export
rosenpin/master
lazarosfs/EnableBtOnConnect
health-new-database
mi2-text-notifications
polarm400
release-0.11.x
led-profile
live-sensor-data
0.80.0
0.79.1
0.79.0
0.78.0
0.77.0
0.76.1
0.76.0
0.75.1
0.75.0
0.74.0
0.73.0
0.72.0
0.71.3
0.71.2
0.71.1
0.71.0
0.70.0
0.69.0
0.68.0
0.67.1
0.67.0
0.66.0
0.65.0
0.64.0
0.63.1
0.63.0
0.62.0
0.61.0
0.60.0
0.59.3
0.59.2
0.59.1
0.59.0
0.58.2
0.58.1
0.58.0
0.57.1
0.57.0
0.56.2
0.56.1
0.56.0
0.55.0
0.54.1
0.54.0
0.53.0
0.52.0
0.51.0
0.50.0
0.49.0
0.48.0
0.47.2
0.47.1
0.47.0
0.46.0
0.45.1
0.45.0
0.44.2
0.44.1
0.44.0
0.43.3
0.43.2
0.43.1
0.43.0
0.42.1
0.42.0
0.41.1
0.41.0
0.40.1
0.40.0
0.39.1
0.39.0
0.38.0
0.37.1
0.37.0
0.36.2
0.36.1
0.36.0
0.35.2
0.35.1
0.35.0
0.34.1
0.34.0
0.33.1
0.33.0
0.32.4
0.32.3
0.32.2
0.32.1
0.32.0
0.31.3
0.31.2
0.31.1
0.31.0
0.30.0
0.29.1
0.29.0
0.28.1
0.28.0
0.27.1
0.27.0
0.26.5
0.26.4
0.26.3
0.26.2
0.26.1
0.26.0
0.25.1
0.25.0
0.24.6
0.24.5
0.24.4
0.24.3
0.24.2
0.24.1
0.24.0
0.23.2
0.23.1
0.23.0
0.22.5
0.22.4
0.22.3
0.22.2
0.22.1
0.22.0
0.21.6
0.21.5
0.21.4
0.21.3
0.21.2
0.21.1
0.21.0
0.20.2
0.20.1
0.20.0
0.19.4
0.19.3
0.19.2
0.19.1
0.19.0
0.18.5
0.18.4
0.18.3
0.18.2
0.18.1
0.18.0
0.17.5
0.17.4
0.17.3
0.17.2
0.17.1
0.17.0
0.16.0
0.15.2
0.15.1
0.15.0
0.14.4
0.14.3
0.14.2
0.14.1
0.14.0
0.13.9
0.13.8
0.13.7
0.13.6
0.13.5
0.13.4
0.13.3
0.13.2
0.13.1
0.13.0
0.12.2
0.11.2
0.11.1
0.11.0
0.10.2
0.10.1
0.10.0
0.9.8
0.9.7
0.9.6
0.9.5
0.9.4
0.9.3
0.9.2
0.9.1
0.9.0
0.8.2
0.8.1
0.8.0
0.7.4
0.7.3
0.7.2
0.7.1
0.7.0
0.6.9
0.6.8
0.6.7
0.6.6
0.6.5
0.6.4
0.6.3
0.6.2
0.6.1
0.6.0
0.5.4
0.5.3
0.5.2
0.5.1
0.5.0
0.4.6
0.4.5
0.4.4
0.4.3
0.4.2
0.4.1
0.4.0
0.3.5
0.3.4
0.3.3
0.3.2
0.3.1
0.3.0
0.2.0
0.1.5
0.1.4
0.1.3
0.1.2
0.1.1
0.1.0
Labels
Clear labels   
device mi band 7

Mi Band 7

  
activity post processing

activity data processing, import, export

  
activity/health

   
Android 12

   
Android 13

   
android integrations

   
architecture

  
Bangle.js

   
bug

   
changes requested

the provided PR needs some modifications

  
charts

   
details not provided

  
developer documentation

Information for contributors

  
device amazfit band 5

Amazfit Band 5

  
device amazfit bip

   
device amazfit cor

   
device Casio

   
device fossil

   
device garmin

   
device gtr 2e

   
device gts 2 mini

   
device h30

   
device hplus

   
device huami

   
device Huawei

Huawei honor

  
device liveview

   
device mi band

   
device mi band 2

   
device mi band 3

   
device mi band 4

   
device mi band 5

Mi Smart Band 5

  
device mi band 6

Mi Smart Band 6

  
device no.1 f1

   
device pace

   
device pebble

   
device pebble 2

   
device pinetime infinitime

   
device request

   
device sony

Sony

  
device support

   
device watch 9

   
device xiaomi

   
discussion

   
documentation

   
duplicate

   
enhancement

   
feature request

   
Gadgetbridge

Gadgetbridge

  
good first issue

good entry level issue for new contributors

  
help wanted

   
i am developing my own app can you help

no, sorry

  
icebox

An icebox for abandoned PRs. Feel free to pick it up, update and make a new PR

  
intent api

   
internationalisation

metric/imperial/celsius/fahrentheit...

  
invalid

   
needs work

   
network companion app

ideas pool for a network enabled companion app

  
new device

   
no feedback

   
not a bug

   
notifications

ideas and improvements for notifications

  
one of the 1000 issues about disconnection

   
pairing/connecting

   
potentially fixed / confirm and close

   
question

   
research

   
security

   
seems abandoned

PR seems to abandoned

  
Solved, waiting for F-Droid release

   
suggest to close

probably should/could close

  
task

   
user interface / UX

   
wear os

   
weather

   
wontfix

   
Zepp OS
No Label
device mi band 7
activity post processing
activity/health
Android 12
Android 13
android integrations
architecture
Bangle.js
bug
changes requested
charts
details not provided
developer documentation
device amazfit band 5
device amazfit bip
device amazfit cor
device Casio
device fossil
device garmin
device gtr 2e
device gts 2 mini
device h30
device hplus
device huami
device Huawei
device liveview
device mi band
device mi band 2
device mi band 3
device mi band 4
device mi band 5
device mi band 6
device no.1 f1
device pace
device pebble
device pebble 2
device pinetime infinitime
device request
device sony
device support
device watch 9
device xiaomi
discussion
documentation
duplicate
enhancement
feature request
Gadgetbridge
good first issue
help wanted
i am developing my own app can you help
icebox
intent api
internationalisation
invalid
needs work
network companion app
new device
no feedback
not a bug
notifications
one of the 1000 issues about disconnection
pairing/connecting
potentially fixed / confirm and close
question
research
security
seems abandoned
Solved, waiting for F-Droid release
suggest to close
task
user interface / UX
wear os
weather
wontfix
Zepp OS
Milestone
Clear milestone
No items
No Milestone
Assignees
Clear assignees
No Assignees
3 Participants
Notifications
Due Date
The due date is invalid or out of range. Please use the format 'yyyy-mm-dd'.

No due date set.

Dependencies

No dependencies set.

Reference: Freeyourgadget/Gadgetbridge#2996
No description provided.
Delete Branch "%!s(<nil>)"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?