Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Workaround for building on gcc versions > 6. #1633

Merged
merged 1 commit into from Mar 18, 2019

Conversation

dgazzoni
Copy link
Contributor

No description provided.

@MaBecker
Copy link
Contributor

Hi, @swineone,
what is the benefit of using a higher gcc version?

@dgazzoni
Copy link
Contributor Author

Hi, @swineone,
what is the benefit of using a higher gcc version?

No idea, really. I'm just used to updating when new versions coming out -- I assume optimizations are better, etc.

Hopefully this doesn't dissuade anyone from merging this fix, as it's as simple and harmless as it gets.

@gfwilliams
Copy link
Member

Thanks for this - newer GCCs do sometimes get better code density and speed, but I've had issues with some (sometimes the manufacturer-provided HALs do non-compliant stuff and end up getting broken) so I don't tend to change compiler unless there's a good reason.

Do you have any background as to why swapping the order of object files around actually helps? What error does it fix? It just seems like something that shouldn't really have any effect at all?

@gfwilliams
Copy link
Member

Aha - I just spotted your forum post - thanks! Loads of info there :)

http://forum.espruino.com/conversations/331066/#comment14658810

@gfwilliams gfwilliams merged commit 8ce3550 into espruino:master Mar 18, 2019
@dgazzoni dgazzoni deleted the gcc8-fix branch April 23, 2019 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants