This repository has been archived by the owner on Aug 4, 2021. It is now read-only.
fix: avoid ES6 export for entry files w/o exports #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opichals
added a commit
to opichals/rollup-plugin-espruino-modules
that referenced
this pull request
Nov 7, 2018
|
Thanks for opening this PR and I'm sorry that it didn't get the attention that it needed. We're getting ready to move this plugin to a new home at https://github.com/rollup/plugins, and that should mean all the plugins get more TLC moving forward. I resolved the conflicts in your PR but it looks like there are some issue with CI. If you can clean those up this week, we'll take a look at getting this merged. If not, no worries, a new PR will be welcome at the new repo. |
opichals
force-pushed
the
no-export-default-if-none-found
branch
2 times, most recently
from
7aa864f
to
64a343d
Compare
No ES6 export is added to _entry_ files containing no CommonJS export.
E.g. this:
```
var dummy = require('./dummy');
var input = 42;
```
Is now transformed into the following containing no ES6 export:
```
import './dummy';
import dummy from 'commonjs-proxy:./dummy';
var input = 42;
```
opichals
force-pushed
the
no-export-default-if-none-found
branch
from
64a343d
to
8048cdf
Compare
|
@shellscape Thank you! I have rebased this and adapted to work on top of master. |
|
Cheers 🍺 Thanks |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No ES6 export is added to entry files containing no CommonJS export.
E.g. this entry file named
xyz/index.jscontainingThis PR makes the above code which doesn't contain any
exportsuse transformed into the following containing no ES6 export:In master branchy it adds an empty object
module.exportsclause which is useful for non-entry files but not desirable for entry files: