Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Blocky module for amperka's motor shield. #150

Merged
merged 5 commits into from Dec 5, 2016

Conversation

mickvav
Copy link
Contributor

@mickvav mickvav commented Nov 21, 2016

Hello.
I've just got amperka's motor shield and decided to help my son deal with it using blocky GUI, but found that
digitalWrite/analogWrite is not intuitive enought - so I've made some coding & testing after copy-pasteing Robot code - the result seems to work.
Idea - we have 2 blocks - direction and speed, available for each motor, managed by motorshield.

Made things strickter.
Debugged and tested. Works with Amperka motor shield.
1) support blockly.local.html and corresponding config option.
2) Russian locale support
3) Move strings to english locale
@gfwilliams
Copy link
Member

Thanks - looks good (the motor shield stuff is still in there by default and there's no way to change the language without adding your own Blockly HTML though?).

@mickvav
Copy link
Contributor Author

mickvav commented Nov 25, 2016

Well, I can comment out MotorShield stuff, if it matters. About localization - it's a point to discuss. Right now - yes, I mean that any not-straight-simple behavior should be explicitly enabled by user, demonstrating that he is skillful enough. I think, I can add config option like "Select language", which adds corresponding code, but I am afraid that user would expect that all the GUI will be localized, not just blockly part. And I am not sure that I am ready to translate ALL the GUI :(.

@gfwilliams
Copy link
Member

There's a forum thread asking about localisation too now :) http://forum.espruino.com/conversations/296674/#comment13344605

Sorry for the delay - I will get this merged, but I'm out of the country at the moment.

@gfwilliams
Copy link
Member

Thanks!

@gfwilliams gfwilliams merged commit 1d04237 into espruino:gh-pages Dec 5, 2016
@mickvav
Copy link
Contributor Author

mickvav commented Dec 6, 2016

Great!

@gfwilliams
Copy link
Member

I've updated the IDE online now - hopefully you can see what I've done? I made it so you can change language and add your motor shield stuff without having to install anything custom

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants