Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert apps to use require("widget_utils").hide()/show() rather than duplicating code #2196

Closed
19 tasks done
gfwilliams opened this issue Oct 26, 2022 · 7 comments
Closed
19 tasks done

Convert apps to use require("widget_utils").hide()/show() rather than duplicating code #2196

gfwilliams opened this issue Oct 26, 2022 · 7 comments

Comments

@gfwilliams
Copy link
Member

gfwilliams commented Oct 26, 2022 •
edited

Currently every app that wants to hide widgets does so with its own code. I just added a library and it'd be nice to change apps to use this.

Apps that look like they need changes right now are:

  • apps/lcars/lcars.app.js
  • apps/advcasio/app.js
  • apps/neonx/neonx.app.js
  • apps/pebbled/pebbled.app.js
  • apps/notanalog/notanalog.app.js
  • apps/aiclock/aiclock.app.js
  • apps/macwatch2/app.js
  • apps/limelight/limelight.app.js
  • apps/cassioWatch/app.js
  • apps/daisy/app.js
  • apps/pebble/pebble.app.js
  • apps/thering/app.js
  • apps/rebble/rebble.app.js
  • apps/imageclock/app.js
  • apps/widviz/widget.js
  • apps/bwclk/app.js
  • apps/circlesclock/app.js (still includes fallback code)
  • apps/90sclk/app.js
  • apps/widviztime/widget.js ?
@Darin755
Copy link
Contributor

Did you mean convert?

@myxor
Copy link
Contributor

myxor commented Oct 31, 2022

Circlesclock is done with #2202

@gfwilliams gfwilliams changed the title Covert apps to use require("widget_utils").hide()/show() rather than duplicating code Convert apps to use require("widget_utils").hide()/show() rather than duplicating code Oct 31, 2022
@Rarder44 Rarder44 mentioned this issue Nov 4, 2022
Merged
@halemmerich halemmerich mentioned this issue Nov 21, 2022
Merged
@gfwilliams
Copy link
Member Author

Just to add - for anyone else looking at this, widget_utils now contains slideOn which allows the widgets to be slid onto the screen with a downwards swipe

gfwilliams added a commit that referenced this issue Nov 23, 2022
@gfwilliams
Widgets can now be made visible by swiping down (#2196)
d90959d
@thyttan
Copy link
Collaborator

thyttan commented Dec 1, 2022

#2342 for aiclock

@Rarder44
Copy link
Contributor

Rarder44 commented Dec 2, 2022

#2227 for rebble

This was referenced Jan 11, 2023
Closed
Merged
Merged
@thyttan
Copy link
Collaborator

thyttan commented Feb 7, 2023 •
edited

I suggest closing this since #2492 was merged.

@gfwilliams
Copy link
Member Author

Yes,great - thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@gfwilliams @Rarder44 @myxor @Darin755 @thyttan