Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gbridge fixes #1058

Merged
merged 5 commits into from Dec 13, 2021
Merged

Gbridge fixes #1058

merged 5 commits into from Dec 13, 2021

Conversation

adamschmalhofer
Copy link
Contributor

Two rather single fixes for gbridge:

@johan-m-o
Copy link
Contributor

The call notification bug should be fixed on the Gadgetbridge side though. This is just a bandaid that doesn't actually fix anything...

@myxor
Copy link
Contributor

myxor commented Dec 11, 2021

Reference: #985

@gfwilliams
Copy link
Member

Thanks! Not sure how that lastSentSteps = 0; bug got in there, I was certain this worked fine when I did it!

Lets keep the call hack in there, but as @johan-m-o says we need to fix this in Gadgetbridge. I'm still a big confused about why it'd happening as the build done from Github works great - it's as if the release build doesn't have everything in from master.

@gfwilliams gfwilliams merged commit 821a49c into espruino:master Dec 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants