Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering service uuids in parameters for startScanning() is not reliable. #18

Open
pursual opened this issue Aug 31, 2020 · 3 comments
Labels
help wanted Extra attention is needed

Comments

@pursual
Copy link

pursual commented Aug 31, 2020

The noble lib allows you to provide two parameters to startScanning() (an array of service uuids, and a boolean for allow duplicates).

This binding does not discover anything when an array of service ids is passed?

@pursual
Copy link
Author

pursual commented Aug 31, 2020

It looks like it works when the array only contains one item?

This might be miscoded. Instead of matching any of the service uuids, it might be trying to match only advertisements which contain ALL of them. I do not have a device that broadcasts moret than 1 service uuid, so unable to confirm.

Regardless it does not work with more than one service uuid. noble_uwp and other bindings do.

@pursual pursual changed the title Does not accept service uuids to filter in parameters for startScanning() like other biindings? Filtering service uuids in parameters for startScanning() is not reliable. Aug 31, 2020
@geovie
Copy link
Contributor

geovie commented Sep 1, 2020

@pursual You're right currently we pass the service uuids as filter to the AdvertismentWatcher.

The alternative would be to watch for all and filter the advertisement manually once we receive it.

If anyone wants to provide a PR for this the steps would be:

@geovie geovie added the help wanted Extra attention is needed label Sep 1, 2020
@tony-gutierrez
Copy link
Contributor

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants