New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix run notifications bugs and improve accuracy #1619
Conversation
Thanks! Does the GPS state thing really help to fix a problem though? It seems that because we measure distance as that between the current and last period, setting it to {} may actually have the effect of skipping out one second's worth of distance? |
If you stop a run and start another it would have the old GPS state and if you had moved at all it could cause the initial distance calculation of the second run to be wrong by the distance you had traveled between stopping and starting. |
Do you actually see this happening though? Or is it just what you think might be an issue? Because I believe GPS is on all the time so those should update every second regardless of whether you have started the run or not. |
I see what you're saying and it might have then been a coincidence because I was having trouble with the initial distance on a second run and then it went away after making that change. Perhaps I had a better GPS fix by that point, though it had been around 30 minutes of consistent testing by then. I had assumed that when If the GPS is always on with exstats then does that mean leaving the watch on the |
It looks like the GPS 'fix' likely caused this issue? #1630
Yes, that's the case. But it's important the GPS is turned on as soon as possible, because it can take a while to get a lock. Last thing you want it to start recording and then have it miss the first 10 minutes of your run |
@gfwilliams I went back and tested and retested and could not duplicate the issue that caused me to introduce this breaking change, instead confirming the GPS fix is updating nearly once per second as you said, regardless of whether a run is active. Would you like me to revert it and/or the change from #1630 or leave things as-is? |
Thanks for checking into this! I've just removed the |
This fixes a few issues with the
run
app, mostly ones I introduced with the notifications, but not exclusively. It also removes an unnecessary variable assignment in therecorder
app.recorder
widget is unavailablevibTimes
rather than thevibPatterns
to determine the current notification configurationreset
to prevent distance miscalculation when stopping one run and starting another