Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Presentor V0.08 -> V0.14 #3115

Merged
merged 11 commits into from Nov 30, 2023
Merged

Presentor V0.08 -> V0.14 #3115

merged 11 commits into from Nov 30, 2023

Conversation

7kasper
Copy link
Contributor

@7kasper 7kasper commented Nov 29, 2023

Finally I got back to using Bangle in school so that warrented me putting time into improvements in the presentor app.
It now works with windows 11 again also!

This PR fixes some issues and makes the experience a lot better. The app is still in beta I guess but it works well enough for me most of the time 馃槃

@pavelmachek
Copy link
Contributor

I guess it would be normal to advance by one version when the subversions were not in mainline?

@bobrippling
Copy link
Collaborator

Looks great! Really nice interaction with a PC too.

I did notice that it seems to hold the F10 (or stopHolding didn't seem to be called), after I'd let go, perhaps I was using it in an odd way as the code looks alright?


I guess it would be normal to advance by one version when the subversions were not in mainline?

Interesting point - I like that there's several commits for each change so it's easier to view certain alterations, but I don't know what we've done in the past for version bumps like this - @gfwilliams any thoughts?

@gfwilliams
Copy link
Member

This looks great!

I guess it would be normal to advance by one version when the subversions were not in mainline?

I think if you're not making your changes public then increasing just by one is preferable but honestly it doesn't really matter.

If you were making the app available on your personal app loader then there's a really good reason for bumping the version, so other users who might want to use the absolute latest from your app loader can see when there are new versions.

@gfwilliams gfwilliams merged commit e5ebb03 into espruino:master Nov 30, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants