Great first contribution :) Let us know when you're happy with the remaining items on your list and we can re-review

Thanks! I guess my only concern with this is the CSV file already stores steps and time, so it should be easy to work Cadence out from what's in the stored CSV data already - basically just looking at the difference between the last timestamp and this one and doing steps * 60000 / timeDifference?

So we could just have the changes you made to apps/recorder/interface.html, but with a bit of extra code in there to work out the Cadence at the time the file was read back?

Thanks! I guess my only concern with this is the CSV file already stores steps and time, so it should be easy to work Cadence out from what's in the stored CSV data already - basically just looking at the difference between the last timestamp and this one and doing steps * 60000 / timeDifference?

So we could just have the changes you made to apps/recorder/interface.html, but with a bit of extra code in there to work out the Cadence at the time the file was read back?

That sounds like a better solution. I will revert and reimplement. Thanks

oops didn't mean to close it

I got the cadence log in the gpx output to work. However, it appears that Strava doubles the cadence value. This is probably because gpx cadence for bikes is rotations/min whereas for running it is steps/min, and two steps is one cycle.

Source: Garmin GPX schema:

<xsd:element name="cad" type="RevolutionsPerMinute_t" minOccurs="0"/>

I believe the standard is one revolution is two steps (one step per foot)

I will update the source code to divide by two as that appears to be the standard. I don't believe this will cause a problem on bicycles because step count while cycling is irrelevant.

Off topic:

Hi! Once you're done with this would you be interested in working on gpx-stuff in Gadgetbridge for implementing the 'Activity Tracks' feature for Bangle.js?

https://codeberg.org/Freeyourgadget/Gadgetbridge/pulls/3153#issuecomment-1314419

This looks great - thanks for your work!

Are you happy to merge this now? I know there are some items in the original PR note you haven't marked complete but even so the changes here seem useful

Off topic:

Hi! Once you're done with this would you be interested in working on gpx-stuff in Gadgetbridge for implementing the 'Activity Tracks' feature for Bangle.js?

Sorry, I don't use gadgetbridge (I have an iphone) and I'm not sure I understand what that feature is.

Ah! Thanks anyways then 😉

This looks great - thanks for your work!

Are you happy to merge this now? I know there are some items in the original PR note you haven't marked complete but even so the changes here seem useful

Just tested this and it works as intended. I am ready to merge.

Great - thanks!