Added Utils.readStorageJSON with relaxed JSON parser #3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erface.html over to using it. This allows Bangle.js 2v20 (or cutting edge) and later to store a relaxed 'JSON' on internal storage which (while still normal JS) is smaller and faster (and preserves unicode better) See espruino/Espruino#2429
|
tested read good on calendar, grocery, noteify, openstmap, sleepphasealarm, mylocation, sched, also with special character "\xFC" working |
bobrippling
reviewed
Nov 23, 2023
Co-authored-by: Rob Pilling <robpilling@gmail.com>
bobrippling
approved these changes
Nov 24, 2023
There was a problem hiding this comment.
Looks grand, shall leave to you to merge @gfwilliams in case you're wanting to time it with any other changes
|
Thanks! I won't push this to banglejs.com/apps until next week just in case ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Utils.readStorageJSON and relaxed JSON parser, and swap all interface.html over to using it.
This allows Bangle.js 2v20 (or cutting edge) and later to store a relaxed 'JSON' on internal storage which (while still normal JS) is smaller and faster (and preserves unicode better)
Fixes espruino/Espruino#2429
It'd be great if you could take a look over this as I had to change a bunch of files. I've tried some (eg openstmap) and they work ok, but it may well be I broke something :(