Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[app/openstmap] Unable to upload maps on 2v20 and master #3166

Closed
michaellmonaghan opened this issue Jan 26, 2024 · 4 comments
Closed

[app/openstmap] Unable to upload maps on 2v20 and master #3166

michaellmonaghan opened this issue Jan 26, 2024 · 4 comments

Comments

@michaellmonaghan
Copy link

michaellmonaghan commented Jan 26, 2024 •
edited

Affected hardware version

Bangle 2

Your firmware version

2v20

The bug

Only part of the map is displayed when running firmware 2v20 and master (2v20.34). The first several tiles are displayed, then part of a tile is displayed, then none of the following tiles display. Panning and zooming does not cause missing tiles or part of tile to be displayed. Using the same map image file, the full map can be displayed when running firmware 2v19. The same behavior occurs after a factory reset with no other apps installed and when uploading the map image file on firmware 2v19 before upgrading to 2v20. The map size used was XL (10x10) but the same behavior can be observed for other map sizes.

2v20

screenshot

2v19

screenshot (1)

Installed apps

boot (0.59), launch (0.20), antonclk (0.11), about (0.14), widlock (0.08), widbat (0.12), widbt (0.09), notify (0.13), health (0.28), setting (0.68), sched (0.22), widalarm (0.01), alarm (0.46), messageicons (0.05), messagegui (0.75), widmessages (0.05), android (0.32), clock_info (0.07), bwclk (0.33), 93dub (0.06), mtnclock (0.04), weather (0.26), weatherClock (0.06), locale (0.17), waypoints (0.03), gpsnav (0.08), gpsautotime (0.04), speedalt (0.13), recorder (0.37), hrm (0.11), messages (0.62), thermom (0.07), game1024 (0.11), random (0.02), boxclk (0.05), menuwheel (0.02), openstmap (0.27)
@michaellmonaghan michaellmonaghan changed the title [app/openstmap] Unable to upload maps on 2.20 and master [app/openstmap] Unable to upload maps on 2v20 and master Jan 26, 2024
@nxdefiant
Copy link
Contributor

nxdefiant commented Jan 26, 2024 •
edited

I can reproduce this. For an example 5x5 openstmap tile I can not access the higher frames, e.g.

g.reset().clear();
const img = require("Storage").read("openstmap.2.img");
g.drawImage(img, 0, 0, { "scale": 1.5, "frame": 19 });

on 2v19 produces
dump

and on 2v20 produces
dump

Lower frame numbers do work. I think its best to pass this to @gfwilliams

openstmap.2.img.zip

@gfwilliams
Copy link
Member

Ok, thanks - just tried it here and I see the same thing.

Sorry about this - I'm not sure how that slipped through. It's a strange one as I can't remember anything in particular that would have caused something like this, but I'll look into it in the next few hours

@gfwilliams
Copy link
Member

I've just found the issue - it was some checks in espruino/Espruino@e893f3f that restricted the maximum length of flash-memory-mapped strings.

If you update to a cutting-edge build then this should all be fixed now - Unfortunately it looks like I'll need to push out a 2v21 firmware release pretty soon now

@gfwilliams
Copy link
Member

Just fyi, mentioned on https://forum.espruino.com/conversations/393408/newest/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gfwilliams @nxdefiant @michaellmonaghan